Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 680483002: Add DumpAccessibilityTree tests (5 of 20). (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add DumpAccessibilityTree tests (5 of 20). HTML Tags: head, input type tel, noscript ARIA Role: listbox, separator ARIA state/property: aria-required(true/false) Following HTML tags are undergoing/done in some other CL: HTML Tag - input type num, pre, header, blockquote. HTML ruby tag is not exposed correctly. Will submit it with the fix in new CL. BUG=170577 Committed: https://crrev.com/82dd02e88cff23dbfb40145e3099ade299e0da93 Cr-Commit-Position: refs/heads/master@{#301115}

Patch Set 1 #

Patch Set 2 : uploading expectations for mac and android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -39 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 6 chunks +24 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-listbox.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-listbox-expected-android.txt View 1 1 chunk +4 lines, -7 lines 0 comments Download
A content/test/data/accessibility/aria-listbox-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-listbox-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-required.html View 1 chunk +11 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-required-expected-android.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-required-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-required-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-separator.html View 1 chunk +12 lines, -13 lines 0 comments Download
A content/test/data/accessibility/aria-separator-expected-android.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-separator-expected-mac.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-separator-expected-win.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/head.html View 1 chunk +7 lines, -10 lines 0 comments Download
A content/test/data/accessibility/head-expected-android.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/head-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/head-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/input-tel.html View 1 chunk +9 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/input-tel-expected-android.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + content/test/data/accessibility/input-tel-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/test/data/accessibility/input-tel-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A content/test/data/accessibility/noscript.html View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/noscript-expected-android.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/noscript-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/noscript-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!
6 years, 2 months ago (2014-10-24 11:44:45 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-24 15:13:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680483002/20001
6 years, 2 months ago (2014-10-24 15:15:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-24 16:10:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:10:59 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82dd02e88cff23dbfb40145e3099ade299e0da93
Cr-Commit-Position: refs/heads/master@{#301115}

Powered by Google App Engine
This is Rietveld 408576698