Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 680473002: Enable Service Workers, including the onfetch event, by default. (Closed)

Created:
6 years, 2 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 1 month ago
CC:
blink-reviews, dmurph, falken, horo, jakeachibald_chromium.org, jsbell, kenjibaheux, kinuko, Kunihiko Sakamoto, michaeln, nhiroki, slightlyoff
Project:
blink
Visibility:
Public.

Description

Enable Service Workers, including the onfetch event, by default. BUG=364627 TEST=virtual/stable/webexposed Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dominicc (has gone to gerrit)
PTAL The M40 branch is drawing near, it is time to enable Service Workers so ...
6 years, 2 months ago (2014-10-24 06:53:57 UTC) #2
dominicc (has gone to gerrit)
+jochen; it seems tkent is gone for the day.
6 years, 2 months ago (2014-10-24 07:22:55 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-24 07:26:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680473002/1
6 years, 2 months ago (2014-10-24 09:08:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 184340
6 years, 2 months ago (2014-10-24 09:42:43 UTC) #8
horo
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/678843002/ by horo@chromium.org. ...
6 years, 2 months ago (2014-10-25 00:34:48 UTC) #9
dominicc (has gone to gerrit)
6 years, 1 month ago (2014-10-27 00:23:57 UTC) #10
Message was sent while issue was closed.
OK. The test failures that the directory restriction patch caused don't look
serious, that test just needs to be updated. Let's do that and reland this.

Powered by Google App Engine
This is Rietveld 408576698