Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: ui/events/gestures/gesture_recognizer.h

Issue 680413006: Re-enable Eager Gesture Recognition on Aura (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address jdduke's comments (test fixes pending) Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/gestures/gesture_recognizer.h
diff --git a/ui/events/gestures/gesture_recognizer.h b/ui/events/gestures/gesture_recognizer.h
index 5dc58346cefdabc8d9770c244a6383c982e46c7a..8aad2ca9179e2131cf747384fcace3b3a74c1732 100644
--- a/ui/events/gestures/gesture_recognizer.h
+++ b/ui/events/gestures/gesture_recognizer.h
@@ -28,21 +28,23 @@ class EVENTS_EXPORT GestureRecognizer {
virtual ~GestureRecognizer() {}
// Invoked before event dispatch. If the event is invalid given the current
- // touch sequence, marks it as handled.
+ // touch sequence, returns false.
virtual bool ProcessTouchEventPreDispatch(const TouchEvent& event,
GestureConsumer* consumer) = 0;
+
// Returns a list of zero or more GestureEvents. The caller is responsible for
- // freeing the returned events. Called synchronously after event dispatch.
- virtual Gestures* ProcessTouchEventPostDispatch(
+ // freeing the returned events. Acks the first gesture packet in the queue.
+ virtual Gestures* AckAsyncTouchEvent(
const TouchEvent& event,
ui::EventResult result,
GestureConsumer* consumer) = 0;
+
// Returns a list of zero or more GestureEvents. The caller is responsible for
- // freeing the returned events. Called when a touch event receives an
- // asynchronous ack.
- virtual Gestures* ProcessTouchEventOnAsyncAck(const TouchEvent& event,
- ui::EventResult result,
- GestureConsumer* consumer) = 0;
+ // freeing the returned events. Acks the last gesture packet in the queue.
+ virtual Gestures* AckSyncTouchEvent(
+ const TouchEvent& event,
+ ui::EventResult result,
+ GestureConsumer* consumer) = 0;
// This is called when the consumer is destroyed. So this should cleanup any
// internal state maintained for |consumer|. Returns true iff there was

Powered by Google App Engine
This is Rietveld 408576698