Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: ui/events/gesture_detection/gesture_event_data_packet.h

Issue 680413006: Re-enable Eager Gesture Recognition on Aura (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address jdduke's comments (test fixes pending) Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/gesture_detection/gesture_event_data_packet.h
diff --git a/ui/events/gesture_detection/gesture_event_data_packet.h b/ui/events/gesture_detection/gesture_event_data_packet.h
index 9b115de9ca77b29c2210b4933cd9a78acbb69198..bfdd688abe033f4cb236a821add8b5213d7b559e 100644
--- a/ui/events/gesture_detection/gesture_event_data_packet.h
+++ b/ui/events/gesture_detection/gesture_event_data_packet.h
@@ -29,6 +29,12 @@ class GESTURE_DETECTION_EXPORT GestureEventDataPacket {
TOUCH_TIMEOUT, // Timeout from an existing gesture sequence.
};
+ enum class AckState : int {
+ PENDING,
+ CONSUMED,
+ UNCONSUMED,
+ };
+
GestureEventDataPacket();
GestureEventDataPacket(const GestureEventDataPacket& other);
~GestureEventDataPacket();
@@ -48,6 +54,11 @@ class GESTURE_DETECTION_EXPORT GestureEventDataPacket {
const gfx::PointF& touch_location() const { return touch_location_; }
const gfx::PointF& raw_touch_location() const { return raw_touch_location_; }
+ // If we receive an ack for a packet before it reaches the head of the
+ // queue, we store the ack with the packet.
+ void ack(bool event_consumed);
jdduke (slow) 2014/11/26 16:07:09 Nit: Uppercase. Also, the comment is a little uncl
tdresser 2014/11/27 18:26:24 Done.
+ AckState ack_state() { return ack_state_; }
+
private:
GestureEventDataPacket(base::TimeTicks timestamp,
GestureSource source,
@@ -60,6 +71,7 @@ class GESTURE_DETECTION_EXPORT GestureEventDataPacket {
gfx::PointF touch_location_;
gfx::PointF raw_touch_location_;
GestureSource gesture_source_;
+ AckState ack_state_;
};
} // namespace ui

Powered by Google App Engine
This is Rietveld 408576698