Re-enable Eager Gesture Recognition on Aura

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/auto_reset.h"
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 1986 matching lines @@
   TRACE_EVENT0("input", "RenderWidgetHostViewAura::OnTouchEvent");
   if (touch_editing_client_ && touch_editing_client_->HandleInputEvent(event))
     return;
 
   // Update the touch event first.
   blink::WebTouchPoint* point = UpdateWebTouchEventFromUIEvent(*event,
                                                                 &touch_event_);
 
   // Forward the touch event only if a touch point was updated, and there's a
   // touch-event handler in the page, and no other touch-event is in the queue.
-  // It is important to always consume the event if there is a touch-event
-  // handler in the page, or some touch-event is already in the queue, even if
-  // no point has been updated, to make sure that this event does not get
-  // processed by the gesture recognizer before the events in the queue.
-  if (host_->ShouldForwardTouchEvent())
-    event->StopPropagation();
+  // It is important to always mark events as being handled asynchronously if
+  // there is a touch-event handler in the page, or some touch-event is already
+  // in the queue, even if no point has been updated, to make sure that this
+  // event does not get processed by the gesture recognizer before the events in

[jdduke (slow), 2014/11/12 00:04:52]

Could you split this sentence apart and perhaps tighten up the phrasing?

Perhaps "...even if no point has been updated. This ensures that..."

Then maybe "...before events currently awaiting dispatch in the touch queue"?

[tdresser, 2014/11/12 14:51:25]

Done.

+  // the queue.
+  if (host_->ShouldForwardTouchEvent()) {
+    event->DisableSynchronousHandling();
+    if (point) {
+      host_->ForwardTouchEventWithLatencyInfo(touch_event_, *event->latency());
+    } else {
+      // Fake an ack for the invalid touch event.
+      DCHECK(window_->GetHost());
+      window_->GetHost()->dispatcher()->ProcessedTouchEvent(event, window_,

[jdduke (slow), 2014/11/12 00:04:52]

I've been getting this arg packing style recently as well... Is this a genuine
style change or is our collective clang-format borked?

[tdresser, 2014/11/12 14:51:24]

It doesn't appear to be against the style guide.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Calls

+                                                            ui::ER_HANDLED);
+    }
+  }
 
-  if (point) {
-    if (host_->ShouldForwardTouchEvent())
-      host_->ForwardTouchEventWithLatencyInfo(touch_event_, *event->latency());
+  if (point)
     UpdateWebTouchEventAfterDispatch(&touch_event_, point);
-  }
 }
 
 void RenderWidgetHostViewAura::OnGestureEvent(ui::GestureEvent* event) {
   TRACE_EVENT0("input", "RenderWidgetHostViewAura::OnGestureEvent");
   if ((event->type() == ui::ET_GESTURE_PINCH_BEGIN ||
       event->type() == ui::ET_GESTURE_PINCH_UPDATE ||
       event->type() == ui::ET_GESTURE_PINCH_END) && !pinch_zoom_enabled_) {
     event->SetHandled();
     return;
   }
@@ skipping 511 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // RenderWidgetHostViewBase, public:
 
 // static
 void RenderWidgetHostViewBase::GetDefaultScreenInfo(WebScreenInfo* results) {
   GetScreenInfoForWindow(results, NULL);
 }
 
 }  // namespace content