Re-enable Eager Gesture Recognition on Aura

ui/aura/window_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/window.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 806 matching lines @@
   EXPECT_EQ(2, delegate1.gesture_event_count());
   delegate1.ResetCounts();
 
   // Capturing to w2 should cause the touch to be canceled.
   w2->SetCapture();
   EXPECT_EQ(1, delegate1.touch_event_count());
   EXPECT_EQ(0, delegate2.touch_event_count());
   delegate1.ResetCounts();
   delegate2.ResetCounts();
 
-  // Events now go to w2.
+  // Events are now untargetted.

[sadrul, 2014/12/03 21:30:11]

Why?

[tdresser, 2014/12/05 16:44:31]

Window 2 sees an invalid touch event stream (a move with no associated press).
The eager GR requires that invalid touch events not be dispatched, so w2 doesn't
see that touch move. 

Perhaps "untargetted' isn't quite the correct word, but I'm not sure what would
be better.

Any thoughts?

[sadrul, 2014/12/07 17:25:44]

I was under the impression that existing GR sequences are 'transferred' to the
capturing window, and so the sequence for |w1| would start going to |w2|. But it
doesn't look like that particular code is in //ui/wm, and so does not trigger
here.

Can you verify that tab dragging still works after this change?
I think 'untargeted' is OK.

[tdresser, 2014/12/08 14:49:30]

We do transfer gesture sequences sometimes, but (I think) only when we have a
single sequence being transferred. Suppose I have 3 windows with active touch
sequences when another window gains capture. We can't really transfer all of
those active sequences to the window which just got capture.

Tab dragging does work - I was worried about that as well.

Fixed "targetted".

   ui::TouchEvent move(ui::ET_TOUCH_MOVED, gfx::Point(10, 20), 0, getTime());
   DispatchEventUsingWindowDispatcher(&move);
   EXPECT_EQ(0, delegate1.gesture_event_count());
   EXPECT_EQ(0, delegate1.touch_event_count());
   EXPECT_EQ(0, delegate2.gesture_event_count());
-  EXPECT_EQ(1, delegate2.touch_event_count());
+  EXPECT_EQ(0, delegate2.touch_event_count());
 
   ui::TouchEvent release(
       ui::ET_TOUCH_RELEASED, gfx::Point(10, 20), 0, getTime());
   DispatchEventUsingWindowDispatcher(&release);
   EXPECT_EQ(0, delegate1.gesture_event_count());
   EXPECT_EQ(0, delegate2.gesture_event_count());
 
   // A new press is captured by w2.
   ui::TouchEvent press2(
       ui::ET_TOUCH_PRESSED, gfx::Point(10, 10), 0, getTime());
@@ skipping 2597 matching lines @@
 
   EXPECT_TRUE(animator.get());
   EXPECT_FALSE(animator->is_animating());
   EXPECT_TRUE(observer.animation_completed());
   EXPECT_FALSE(observer.animation_aborted());
   animator->RemoveObserver(&observer);
 }
 
 }  // namespace test
 }  // namespace aura