src/effects/SkAlphaThresholdFilter.cpp - Issue 680413005: Don't allow renderTarget==NULL to GrContext::clear() and friends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkAlphaThresholdFilter.cpp

Issue 680413005: Don't allow renderTarget==NULL to GrContext::clear() and friends. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkAlphaThresholdFilter.cpp

diff --git a/src/effects/SkAlphaThresholdFilter.cpp b/src/effects/SkAlphaThresholdFilter.cpp

index 326f005e36290310c1685e747d05c3e8507e7056..c3ad87a3b8a23bb91f8b1db54d1e26c98441abc2 100644

--- a/src/effects/SkAlphaThresholdFilter.cpp

+++ b/src/effects/SkAlphaThresholdFilter.cpp

@@ -294,7 +294,7 @@ bool SkAlphaThresholdFilterImpl::asFragmentProcessor(GrFragmentProcessor** fp,

GrPaint grPaint;

grPaint.setBlendFunc(kOne_GrBlendCoeff, kZero_GrBlendCoeff);

SkRegion::Iterator iter(fRegion);

- context->clear(NULL, 0x0, true);

+ context->clear(NULL, 0x0, true, maskTexture->asRenderTarget());

SkMatrix old_matrix = context->getMatrix();

context->setMatrix(in_matrix);

« no previous file with comments | « include/gpu/GrContext.h ('k') | src/effects/SkGpuBlurUtils.cpp » ('j') | no next file with comments »