Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 680413005: Don't allow renderTarget==NULL to GrContext::clear() and friends. (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Don't allow renderTarget==NULL to GrContext::clear() and friends. Committed: https://skia.googlesource.com/skia/+/89c62980c1eb50b2090f33312086c7e8c66739b4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -58 lines) Patch
M include/gpu/GrContext.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 4 chunks +10 lines, -12 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +7 lines, -11 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
A small step towards making GrContext/GrDrawTarget less stateful.
6 years, 1 month ago (2014-11-03 17:42:29 UTC) #2
joshualitt
https://codereview.chromium.org/680413005/diff/1/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/680413005/diff/1/src/gpu/GrContext.cpp#newcode1539 src/gpu/GrContext.cpp:1539: if (!target->surfacePriv().hasPendingIO()) { is the ! correct here?
6 years, 1 month ago (2014-11-03 19:33:15 UTC) #3
bsalomon
https://codereview.chromium.org/680413005/diff/1/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/680413005/diff/1/src/gpu/GrContext.cpp#newcode1539 src/gpu/GrContext.cpp:1539: if (!target->surfacePriv().hasPendingIO()) { On 2014/11/03 19:33:14, joshualitt wrote: > ...
6 years, 1 month ago (2014-11-03 19:59:19 UTC) #4
joshualitt
On 2014/11/03 19:59:19, bsalomon wrote: > https://codereview.chromium.org/680413005/diff/1/src/gpu/GrContext.cpp > File src/gpu/GrContext.cpp (right): > > https://codereview.chromium.org/680413005/diff/1/src/gpu/GrContext.cpp#newcode1539 > ...
6 years, 1 month ago (2014-11-03 20:00:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680413005/20001
6 years, 1 month ago (2014-11-03 20:01:10 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 20:08:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 89c62980c1eb50b2090f33312086c7e8c66739b4

Powered by Google App Engine
This is Rietveld 408576698