Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 680403002: Fix Print Preview navbar links layout (Closed)

Created:
6 years, 1 month ago by Aleksey Shlyapnikov
Modified:
6 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Print Preview navbar links layout (broken by crrev.com/668983004). BUG=399376, 427388 Committed: https://crrev.com/e60561ddb24168c6682466b91567b6f9d54cae94 Cr-Commit-Position: refs/heads/master@{#301915}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unnecessary navbar-link CSS styles. #

Total comments: 4

Patch Set 3 : Properly disable navbar links. #

Patch Set 4 : Merging with head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M chrome/browser/resources/print_preview/print_header.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.css View 1 2 2 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 2 3 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dan Beam
lgtm https://codereview.chromium.org/680403002/diff/1/chrome/browser/resources/print_preview/print_preview.css File chrome/browser/resources/print_preview/print_preview.css (right): https://codereview.chromium.org/680403002/diff/1/chrome/browser/resources/print_preview/print_preview.css#newcode128 chrome/browser/resources/print_preview/print_preview.css:128: text-align: start; ^ what's this for? https://codereview.chromium.org/680403002/diff/1/chrome/browser/resources/print_preview/print_preview.css#newcode129 chrome/browser/resources/print_preview/print_preview.css:129: ...
6 years, 1 month ago (2014-10-28 20:38:38 UTC) #2
Aleksey Shlyapnikov
https://codereview.chromium.org/680403002/diff/1/chrome/browser/resources/print_preview/print_preview.css File chrome/browser/resources/print_preview/print_preview.css (right): https://codereview.chromium.org/680403002/diff/1/chrome/browser/resources/print_preview/print_preview.css#newcode128 chrome/browser/resources/print_preview/print_preview.css:128: text-align: start; On 2014/10/28 20:38:38, Dan Beam wrote: > ...
6 years, 1 month ago (2014-10-28 23:24:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680403002/20001
6 years, 1 month ago (2014-10-29 00:39:43 UTC) #5
Dan Beam
still lgtm https://codereview.chromium.org/680403002/diff/20001/chrome/browser/resources/print_preview/print_preview.css File chrome/browser/resources/print_preview/print_preview.css (right): https://codereview.chromium.org/680403002/diff/20001/chrome/browser/resources/print_preview/print_preview.css#newcode131 chrome/browser/resources/print_preview/print_preview.css:131: text-decoration: underline; is this necessary as well? ...
6 years, 1 month ago (2014-10-29 00:41:49 UTC) #6
Aleksey Shlyapnikov
https://codereview.chromium.org/680403002/diff/20001/chrome/browser/resources/print_preview/print_preview.css File chrome/browser/resources/print_preview/print_preview.css (right): https://codereview.chromium.org/680403002/diff/20001/chrome/browser/resources/print_preview/print_preview.css#newcode131 chrome/browser/resources/print_preview/print_preview.css:131: text-decoration: underline; On 2014/10/29 00:41:48, Dan Beam wrote: > ...
6 years, 1 month ago (2014-10-29 02:15:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680403002/60001
6 years, 1 month ago (2014-10-29 19:21:25 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-29 20:28:03 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 20:28:51 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e60561ddb24168c6682466b91567b6f9d54cae94
Cr-Commit-Position: refs/heads/master@{#301915}

Powered by Google App Engine
This is Rietveld 408576698