Issue 680393005: Cleanup a few loops into the new C++11 for-each style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 680393005: Cleanup a few loops into the new C++11 for-each style. (Closed)

Created:
6 years, 1 month ago by jww

Modified:
6 years, 1 month ago

Reviewers:
Mike West

CC:
blink-reviews, mkwst+watchlist-csp_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Cleanup a few loops into the new C++11 for-each style. Inspired by changes in https://codereview.chromium.org/700463003/, this CL cleans up a few loops where there was an ugly sizeof() calculation needed. The new C++11 for-each style makes these unnecessary, thus making the code more readable and less brittle. R=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184823

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -13 lines)			Patch
	M	Source/core/frame/SubresourceIntegrity.cpp	View		1 chunk	+3 lines, -7 lines	0 comments	Download
	M	Source/core/frame/csp/ContentSecurityPolicy.cpp	View		1 chunk	+4 lines, -6 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680393005/1

6 years, 1 month ago (2014-11-04 07:30:29 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-11-04 09:01:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184823