Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 680393004: Reland Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (Closed)

Created:
6 years, 1 month ago by Mike Lerman
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (patchset #1 id:1 of https://codereview.chromium.org/686683005/) Reason for revert: Undo the revert, it wasn't the cause of the test failures. Original issue's description: > Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (patchset #1 id:1 of https://codereview.chromium.org/696283002/) > > Reason for revert: > Common CL assumed to be causing Android Tests to fail: > > https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16593 > and > http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23875 > > Original issue's description: > > Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). > > > > TBR=machenbach@chromium.org > > > > Committed: https://crrev.com/382af4619960b659a5ac7952dcc04e20ebaf4fe4 > > Cr-Commit-Position: refs/heads/master@{#302437} > > TBR=machenbach@chromium.org,v8-autoroll@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/56957b6e401489d556fe87e5ca77b1e36170314f > Cr-Commit-Position: refs/heads/master@{#302458} TBR=machenbach@chromium.org,v8-autoroll@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/258af79474f58ff4daa9b6c4f6519bc5423abc56 Cr-Commit-Position: refs/heads/master@{#302460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Mike Lerman
Created Revert of Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5).
6 years, 1 month ago (2014-11-03 19:17:33 UTC) #1
Michael Achenbach
Why is this closed without actually landing? I shortened the title a bit - it ...
6 years, 1 month ago (2014-11-03 19:28:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680393004/1
6 years, 1 month ago (2014-11-03 19:31:14 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
6 years, 1 month ago (2014-11-03 19:32:02 UTC) #7
Michael Achenbach
6 years, 1 month ago (2014-11-03 19:45:49 UTC) #9
Message was sent while issue was closed.
Something weird happened here. Apparently rietveld disallows writing messages to
CLs with a title longer than 100 chars. So the CQ couldn't write either -
therefore I didn't see that this actually landed.

On the console view of buildbot this change is now omitted. This might be a
weird feature?

Powered by Google App Engine
This is Rietveld 408576698