Make setRemoteDescription, setLocalDescription et al async.

Make setRemoteDescription, setLocalDescription et al async.
This reduces blocking on the UI thread significantly in the same way
as has been done for getStats.

BUG=378065
Committed: https://crrev.com/72eaef099698d09dbf9f3fe3cf5de2e98259239e
Cr-Commit-Position: refs/heads/master@{#302780}

[tommi (sloooow) - chröme, 2014-11-03 21:12:58]

fetch signaling thread ptr from the factory

[tommi (sloooow) - chröme, 2014-11-03 21:26:16]

Test addIce

[tommi (sloooow) - chröme, 2014-11-03 22:27:31]

Fix content_unittests

[tommi (sloooow) - chröme, 2014-11-04 07:17:52]

More updates

[tommi (sloooow) - chröme, 2014-11-04 17:18:43]

Rebase+remove AddStream/RemoveStream closures

[tommi (sloooow) - chröme, 2014-11-04 21:01:05]

Revert some changes, add TODOs, rebase

[tommi (sloooow) - chröme, 2014-11-04 22:18:07]

String update

[tommi (sloooow) - chröme, 2014-11-04 22:19:11]

updated after the libjingle roll - ptal

[tommi (sloooow) - chröme, 2014-11-04 22:19:29]

tommi@chromium.org changed reviewers:
+ perkj@chromium.org

[tommi (sloooow) - chröme, 2014-11-04 22:19:45]

Hej Per - please review

[perkj_chrome, 2014-11-05 10:31:02]

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:144: void
RunClosureWithTrace(const base::Closure& closure,
static to be consistent with above. Or move all to anonymouse ns. Here and
below.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:161: void
RunSynchronousClosureWithResult(
unused

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:173: void
RunSynchronousClosureOnThread(
unused

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:191: ResultType
RunSynchronousClosureOnThreadWithResultT(
unused?

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:211: static void
GetSessionDescription(
suggest naming GetSdpAndTypeFromSessionDescription?

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:222: description,
Can we rename |description| to something that indicate that this is a
"function"?

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:224:
GetSessionDescription(description.Run(), sdp, type);
Can you please join GetSessionDescription and GetDescripion? 
How about 
void GetSdpAndType(const base::Callback<const
webrtc::SessionDescriptionInterface*()>& get_description_cb,
std::string* sdp, std::string* type) {
webrtc::SessionDescriptionInterface* desc ? get_description_cb.run();
if (desc)...

}

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:980: base::Callback<const
webrtc::SessionDescriptionInterface*()> description =
name get_description_cb?

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:1000: auto desc =
base::Bind(&webrtc::PeerConnectionInterface::remote_description,
please use base::Callback<const webrtc::SessionDescriptionInterface*()> as in
localDescription.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:1001:
native_peer_connection_);
nit: indentation

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:1472: void
RTCPeerConnectionHandler::RunSynchronousClosureOnThread(
Name RunSynchronousClosureOnSignalingThread?

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:1490: bool
RTCPeerConnectionHandler::RunSynchronousClosureOnThreadWithResult(
unused?

[tommi (sloooow) - chröme, 2014-11-05 10:37:22]

Remove dead code

[tommi (sloooow) - chröme, 2014-11-05 10:50:14]

Address comments

[tommi (sloooow) - chröme, 2014-11-05 10:50:39]

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:144: void
RunClosureWithTrace(const base::Closure& closure,
On 2014/11/05 10:31:02, perkj wrote:
> static to be consistent with above. Or move all to anonymouse ns. Here and
> below.

Done.  Moved all into an anonymous namespace.  Had to move the implementation of
LocalRTCStatsRequest down a bit because of that.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:161: void
RunSynchronousClosureWithResult(
On 2014/11/05 10:31:02, perkj wrote:
> unused

Done.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:173: void
RunSynchronousClosureOnThread(
On 2014/11/05 10:31:01, perkj wrote:
> unused

Done.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:191: ResultType
RunSynchronousClosureOnThreadWithResultT(
On 2014/11/05 10:31:01, perkj wrote:
> unused?

Done.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:211: static void
GetSessionDescription(
On 2014/11/05 10:31:02, perkj wrote:
> suggest naming GetSdpAndTypeFromSessionDescription?

Done.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:222: description,
On 2014/11/05 10:31:02, perkj wrote:
> Can we rename |description| to something that indicate that this is a
> "function"?

Renamed to description_callback

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:224:
GetSessionDescription(description.Run(), sdp, type);
On 2014/11/05 10:31:02, perkj wrote:
> Can you please join GetSessionDescription and GetDescripion? 
> How about 
> void GetSdpAndType(const base::Callback<const
> webrtc::SessionDescriptionInterface*()>& get_description_cb,
> std::string* sdp, std::string* type) {
> webrtc::SessionDescriptionInterface* desc ? get_description_cb.run();
> if (desc)...
> 
> }

Done.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:980: base::Callback<const
webrtc::SessionDescriptionInterface*()> description =
On 2014/11/05 10:31:02, perkj wrote:
> name get_description_cb? 

Done. changed to description_cb (since the function name doesn't have a get_)

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:1000: auto desc =
base::Bind(&webrtc::PeerConnectionInterface::remote_description,
On 2014/11/05 10:31:02, perkj wrote:
> please use base::Callback<const webrtc::SessionDescriptionInterface*()> as in
> localDescription.

Done.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:1001:
native_peer_connection_);
On 2014/11/05 10:31:02, perkj wrote:
> nit: indentation

Done.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:1472: void
RTCPeerConnectionHandler::RunSynchronousClosureOnThread(
On 2014/11/05 10:31:01, perkj wrote:
> Name RunSynchronousClosureOnSignalingThread?

Done.

https://codereview.chromium.org/680393003/diff/130001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:1490: bool
RTCPeerConnectionHandler::RunSynchronousClosureOnThreadWithResult(
On 2014/11/05 10:31:01, perkj wrote:
> unused?

Removed

[perkj_chrome, 2014-11-05 11:00:57]

The CQ bit was checked by perkj@chromium.org

[perkj_chrome, 2014-11-05 11:00:59]

lgtm

lgtm. Please do a follow up cl to add a content browsertest that call pc.close
while waiting for setlocal and/or setRemote as discussed.

[commit-bot: I haz the power, 2014-11-05 11:02:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680393003/170001

[commit-bot: I haz the power, 2014-11-05 11:46:27]

Committed patchset #10 (id:170001)

[commit-bot: I haz the power, 2014-11-05 11:47:11]

Patchset 10 (id:??) landed as
https://crrev.com/72eaef099698d09dbf9f3fe3cf5de2e98259239e
Cr-Commit-Position: refs/heads/master@{#302780}