DeviceOrientation API on ChromeOS

content/browser/device_sensors/data_fetcher_shared_memory_default.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "data_fetcher_shared_memory.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
+#include "content/public/browser/sensor_manager.h"
 
 namespace {
 
 static bool SetMotionBuffer(content::DeviceMotionHardwareBuffer* buffer,
     bool enabled) {
   if (!buffer)
     return false;
   buffer->seqlock.WriteBegin();
   buffer->data.allAvailableSensorsAreActive = enabled;
   buffer->seqlock.WriteEnd();
@@ skipping 37 matching lines @@
   switch (consumer_type) {
     case CONSUMER_TYPE_MOTION:
       motion_buffer_ = static_cast<DeviceMotionHardwareBuffer*>(buffer);
       UMA_HISTOGRAM_BOOLEAN("InertialSensor.MotionDefaultAvailable", false);
       return SetMotionBuffer(motion_buffer_, true);
     case CONSUMER_TYPE_ORIENTATION:
       orientation_buffer_ =
           static_cast<DeviceOrientationHardwareBuffer*>(buffer);
       UMA_HISTOGRAM_BOOLEAN("InertialSensor.OrientationDefaultAvailable",
           false);
+      SensorManager::GetInstance()->StartFetchingDeviceOrientationData(

[timvolodine, 2014/11/06 02:53:47]

this line shouldn't be here. the purpose of _default is to provide "null" values
on platforms where the api is not supported.
looks like this should be in a file called
data_fetcher_shared_memory_chromeos.cc instead.

[jonross, 2014/11/06 18:18:52]

Done.

+          orientation_buffer_);
       return SetOrientationBuffer(orientation_buffer_, true);
     case CONSUMER_TYPE_LIGHT:
       light_buffer_ = static_cast<DeviceLightHardwareBuffer*>(buffer);
       return SetLightBuffer(light_buffer_,
                             std::numeric_limits<double>::infinity());
     default:
       NOTREACHED();
   }
   return false;
 }
 
 bool DataFetcherSharedMemory::Stop(ConsumerType consumer_type) {
   switch (consumer_type) {
     case CONSUMER_TYPE_MOTION:
       return SetMotionBuffer(motion_buffer_, false);
     case CONSUMER_TYPE_ORIENTATION:
+      SensorManager::GetInstance()->StopFetchingDeviceOrientationData();
       return SetOrientationBuffer(orientation_buffer_, false);
     case CONSUMER_TYPE_LIGHT:
       return SetLightBuffer(light_buffer_, -1);
     default:
       NOTREACHED();
   }
   return false;
 }
 
 }  // namespace content