Use SkTypeface::getBounds() in bounding-box calculations.

Use SkTypeface::getBounds() in bounding-box calculations.

This should produce tighter conservative bounding boxes for text than the
approximation code it replaces.

Recording performance is neutral on my desktop.  Playback performance
improves by up to 15% on text heavy pages, e.g.

  desk_pokemonwiki.skp_1 3.24ms -> 2.83ms  0.87x
        desk_baidu.skp_1 1.91ms -> 1.58ms  0.83x

Committed: https://skia.googlesource.com/skia/+/bf8dc343df4fbdcb8af546eb68b640e011a33489

CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot

Committed: https://skia.googlesource.com/skia/+/c51add674dfb89b988a7fbc05f41838c203f9dcd

[mtklein, 2014-10-28 17:11:10]

mtklein@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[mtklein, 2014-10-28 17:13:50]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-28 17:14:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680363003/1

[commit-bot: I haz the power, 2014-10-28 17:14:15]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-28 23:14 UTC

[commit-bot: I haz the power, 2014-10-28 17:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-28 17:22:35]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[reed1, 2014-10-28 17:36:13]

lgtm w/ comments/questions

https://codereview.chromium.org/680363003/diff/20001/src/core/SkRecordDraw.cpp
File src/core/SkRecordDraw.cpp (right):

https://codereview.chromium.org/680363003/diff/20001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:452: SkScalar max = SkTMax(SkTMax(-pad.fLeft,
pad.fRight),
/* we take the max, instead of outsetting by each value because ... ?

https://codereview.chromium.org/680363003/diff/20001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:476: const SkRect tb = tf->getBounds();
// "outset" rect by the corresponding fields in the typeface bounds,
// since rect was built just from the text's origin points.

[mtklein, 2014-10-28 17:51:56]

On 2014/10/28 17:36:13, reed1 wrote:
> lgtm w/ comments/questions
> 
> https://codereview.chromium.org/680363003/diff/20001/src/core/SkRecordDraw.cpp
> File src/core/SkRecordDraw.cpp (right):
> 
>
https://codereview.chromium.org/680363003/diff/20001/src/core/SkRecordDraw.cp...
> src/core/SkRecordDraw.cpp:452: SkScalar max = SkTMax(SkTMax(-pad.fLeft,
> pad.fRight),
> /* we take the max, instead of outsetting by each value because ... ?
> 
>
https://codereview.chromium.org/680363003/diff/20001/src/core/SkRecordDraw.cp...
> src/core/SkRecordDraw.cpp:476: const SkRect tb = tf->getBounds();
> // "outset" rect by the corresponding fields in the typeface bounds,
> // since rect was built just from the text's origin points.

Done.

[mtklein, 2014-10-29 14:59:08]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-29 14:59:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680363003/40001

[commit-bot: I haz the power, 2014-10-29 15:12:13]

Committed patchset #3 (id:40001) as bf8dc343df4fbdcb8af546eb68b640e011a33489

[mtklein, 2014-10-29 15:32:22]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/685173002/ by mtklein@google.com.

The reason for reverting is:
http://build.chromium.org/p/client.skia/builders/Test-Win7-ShuttleA-HD2000-x8....

[mtklein, 2014-10-29 18:58:29]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-29 18:59:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680363003/60001

[commit-bot: I haz the power, 2014-10-29 19:10:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-29 19:10:42]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[mtklein, 2014-10-29 19:24:59]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-29 19:25:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680363003/80001

[mtklein, 2014-10-29 19:36:35]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-10-29 19:36:37]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-10-29 21:02:41]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-29 21:03:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680363003/80001

[mtklein, 2014-10-29 22:36:10]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-10-29 22:36:22]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-10-29 22:36:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680363003/80001

[commit-bot: I haz the power, 2014-10-29 22:36:43]

Committed patchset #5 (id:80001) as c51add674dfb89b988a7fbc05f41838c203f9dcd

[mtklein, 2014-10-29 23:06:06]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/690833002/ by mtklein@google.com.

The reason for reverting is: Mac mini asserting.