Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: LayoutTests/animations/interpolation/resources/interpolation-test.js

Issue 680343004: Don't run Web Animations interpolation tests for prefixed properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/animations/interpolation/resources/interpolation-test.js
diff --git a/LayoutTests/animations/interpolation/resources/interpolation-test.js b/LayoutTests/animations/interpolation/resources/interpolation-test.js
index 5a4b5c80965e48861d8cddeea73c1349dd75e1d7..c0e2d4b229603f40be63a5a7917e1e5b5750484d 100644
--- a/LayoutTests/animations/interpolation/resources/interpolation-test.js
+++ b/LayoutTests/animations/interpolation/resources/interpolation-test.js
@@ -79,11 +79,15 @@
fragment.appendChild(style);
fragment.appendChild(cssTests);
- if (webAnimationsTest) {
- var waTests = document.createElement('div');
- waTests.id = 'web-animations-tests';
- waTests.textContent = 'Web Animations API:';
- fragment.appendChild(waTests);
+ var waTestsDiv = null;
+ function waTests() {
+ if (!waTestsDiv) {
+ waTestsDiv = document.createElement('div');
+ waTestsDiv.id = 'web-animations-tests';
+ waTestsDiv.textContent = 'Web Animations API:';
+ fragment.appendChild(waTestsDiv);
+ }
+ return waTestsDiv;
}
var updateScheduled = false;
@@ -120,7 +124,7 @@
}
}
var results = document.createElement('pre');
- results.textContent = cssResultString + (webAnimationsTest ? '\n' + waResultString : '');
+ results.textContent = cssResultString + (waTestsDiv ? '\n' + waResultString : '');
results.id = 'results';
document.body.appendChild(results);
}
@@ -201,15 +205,14 @@
var nextCaseId = 0;
var cssTestContainer = createTestContainer(describeCSSTest(params), testId);
cssTests.appendChild(cssTestContainer);
- if (webAnimationsTest) {
- var waTestContainer = createTestContainer(describeWATest(params), testId);
- waTests.appendChild(waTestContainer);
- }
expectations.forEach(function(expectation) {
cssTestContainer.appendChild(makeInterpolationTest(
'css', expectation.at, testId, 'case-' + ++nextCaseId, params, expectation.is));
});
- if (webAnimationsTest) {
+ // We don't support prefixed properties in Web Animations
+ if (webAnimationsTest && params.property[0] != '-') {
+ var waTestContainer = createTestContainer(describeWATest(params), testId);
+ waTests().appendChild(waTestContainer);
expectations.forEach(function(expectation) {
waTestContainer.appendChild(makeInterpolationTest(
'web-animations', expectation.at, testId, 'case-' + ++nextCaseId, params, expectation.is));
@@ -415,10 +418,7 @@
}
function disableWebAnimationsTest() {
- if (webAnimationsTest) {
- fragment.querySelector('#web-animations-tests').remove();
- webAnimationsTest = false;
- }
+ webAnimationsTest = false;
}
window.runAsRefTest = runAsRefTest;

Powered by Google App Engine
This is Rietveld 408576698