Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 680343002: Heap profiler clean-up: remove unused methods (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
Yang, loislo
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Heap profiler clean-up: remove unused methods LOG=N BUG=None R=loislo@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24946

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/heap-snapshot-generator.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yurys
6 years, 1 month ago (2014-10-28 14:05:54 UTC) #2
loislo
lgtm
6 years, 1 month ago (2014-10-28 14:12:04 UTC) #3
yurys
Yang, please stamp.
6 years, 1 month ago (2014-10-28 14:13:24 UTC) #5
Yang
On 2014/10/28 14:13:24, yurys wrote: > Yang, please stamp. lgtm.
6 years, 1 month ago (2014-10-28 14:18:41 UTC) #6
yurys
6 years, 1 month ago (2014-10-28 14:54:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698