Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 68033004: Removed GetActiveEntry references from a bunch of instant search and new tab (Closed)

Created:
7 years, 1 month ago by jww
Modified:
7 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, estade+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Removed GetActiveEntry references from a bunch of instant search and new tab page files. See also https://codereview.chromium.org/66993003/ for relevant LGTMs. BUG=273710 TBR=creis@chromium.org,samarth@chromium.org,sreeram@chromium.org,dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M chrome/browser/ui/search/instant_controller.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/instant_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_page_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_page_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jww
7 years, 1 month ago (2013-11-16 04:59:51 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-11-16 05:01:27 UTC) #2
Charlie Reis
LGTM. You'll need to TBR an owner for the two NTP files as well.
7 years, 1 month ago (2013-11-16 19:21:47 UTC) #3
samarth
search lgtm
7 years, 1 month ago (2013-11-19 00:21:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/68033004/1
7 years, 1 month ago (2013-11-20 04:07:29 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 06:16:27 UTC) #6
Message was sent while issue was closed.
Change committed as 236180

Powered by Google App Engine
This is Rietveld 408576698