ash/wm/workspace/workspace_layout_manager_unittest.cc - Issue 68033003: Undocks window first before side-snapping bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_layout_manager_unittest.cc

Issue 68033003: Undocks window first before side-snapping bounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Undocks window first before side-snapping bounds (rebase) Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/workspace_layout_manager_unittest.cc

diff --git a/ash/wm/workspace/workspace_layout_manager_unittest.cc b/ash/wm/workspace/workspace_layout_manager_unittest.cc

index 4302f1dc44f9bdb6093f59bc2a286b2d743ff77a..a5112b24eb7a180c110a8665ed6204245352f77a 100644

--- a/ash/wm/workspace/workspace_layout_manager_unittest.cc

+++ b/ash/wm/workspace/workspace_layout_manager_unittest.cc

@@ -347,7 +347,7 @@ TEST_F(WorkspaceLayoutManagerTest, WindowShouldBeOnScreenWhenAdded) {

parent->RemoveChild(out_window.get());

out_window->SetBounds(gfx::Rect(-200, -200, 200, 200));

// UserHasChangedWindowPositionOrSize flag shouldn't turn off this behavior.

- wm::GetWindowState(window.get())->set_bounds_changed_by_user(true);

+ wm::GetWindowState(window.get())->SetBoundsChangedByUser(true);

parent->AddChild(out_window.get());

EXPECT_GT(bounds.width(), out_window->bounds().width() * 0.29);

EXPECT_GT(bounds.height(), out_window->bounds().height() * 0.29);