Issue 680313004: Cleanup: Make TogglePinnedToStartScreen() Windows only.

Issue 680313004: Cleanup: Make TogglePinnedToStartScreen() Windows only. (Closed)

Created:
6 years, 1 month ago by Lei Zhang

Modified:
6 years, 1 month ago

Reviewers:
benwells

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Cleanup: Make TogglePinnedToStartScreen() Windows only. Committed: https://crrev.com/5149d2754812d73cee2b9e897b277c2cb8c9fc9a Cr-Commit-Position: refs/heads/master@{#302048}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -15 lines)			Patch
M	chrome/browser/ui/browser_command_controller.cc	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/browser_commands.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/toolbar/bookmark_sub_menu_model.cc	View	2 chunks	+10 lines, -8 lines	0 comments	Download

Total messages: 9 (2 generated)

Lei Zhang

git blame says you added TogglePinnedToStartScreen() ...

6 years, 1 month ago (2014-10-28 21:13:39 UTC) #2

benwells

lgtm. i vaguely remember owners wanting to minimise the ifdeffery.

6 years, 1 month ago (2014-10-29 04:19:23 UTC) #3

Lei Zhang

On 2014/10/29 04:19:23, benwells wrote: > lgtm. i vaguely remember owners wanting to minimise the ...

6 years, 1 month ago (2014-10-29 04:42:32 UTC) #4

benwells

On 2014/10/29 04:42:32, Lei Zhang wrote: > On 2014/10/29 04:19:23, benwells wrote: > > lgtm. ...

6 years, 1 month ago (2014-10-30 05:22:09 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680313004/1

6 years, 1 month ago (2014-10-30 06:43:47 UTC) #7

commit-bot: I haz the power

6 years, 1 month ago (2014-10-30 07:26:21 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5149d2754812d73cee2b9e897b277c2cb8c9fc9a
Cr-Commit-Position: refs/heads/master@{#302048}