Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 680313003: Move input/output counts directly into Operators, simplying OperatorProperties. (Closed)

Created:
6 years, 1 month ago by titzer
Modified:
6 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move input/output counts directly into Operators, simplying OperatorProperties. This is a first step to refactoring OperatorProperties out of existence. The next step is to inline OperatorProperties::GetXXXCount into the callers. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24983

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Addressed review comments. #

Patch Set 4 : Try #

Patch Set 5 : yes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+600 lines, -520 lines) Patch
M src/compiler/common-operator.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/common-operator.cc View 1 2 4 chunks +127 lines, -98 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-operator.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-operator.cc View 1 2 3 4 4 chunks +76 lines, -51 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 4 chunks +113 lines, -109 lines 0 comments Download
M src/compiler/opcodes.h View 5 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/operator.h View 1 2 6 chunks +40 lines, -42 lines 0 comments Download
M src/compiler/operator.cc View 1 2 1 chunk +20 lines, -31 lines 0 comments Download
M src/compiler/operator-properties-inl.h View 1 2 5 chunks +13 lines, -51 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 1 chunk +27 lines, -25 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/simplified-graph-builder.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-graph-reducer.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-node-algorithm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-operator.cc View 7 chunks +102 lines, -47 lines 0 comments Download
M test/cctest/compiler/test-schedule.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/value-numbering-reducer-unittest.cc View 4 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
6 years, 1 month ago (2014-10-28 14:49:28 UTC) #1
rossberg
I love simplying stuff. LGTM, just nits. https://codereview.chromium.org/680313003/diff/20001/src/compiler/common-operator.cc File src/compiler/common-operator.cc (right): https://codereview.chromium.org/680313003/diff/20001/src/compiler/common-operator.cc#newcode292 src/compiler/common-operator.cc:292: static inline ...
6 years, 1 month ago (2014-10-29 09:43:21 UTC) #2
titzer
https://codereview.chromium.org/680313003/diff/20001/src/compiler/common-operator.cc File src/compiler/common-operator.cc (right): https://codereview.chromium.org/680313003/diff/20001/src/compiler/common-operator.cc#newcode292 src/compiler/common-operator.cc:292: static inline size_t CE(Operator::Properties properties) { On 2014/10/29 09:43:21, ...
6 years, 1 month ago (2014-10-29 11:59:26 UTC) #3
titzer
6 years, 1 month ago (2014-10-29 14:41:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as 24983.

Powered by Google App Engine
This is Rietveld 408576698