Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 680293002: Change visibility of stop/reload button if url bar has focus. (Closed)

Created:
6 years, 1 month ago by ankit
Modified:
6 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change visibility of stop/reload button if url bar has focus. If focus is on url bar it does not make sense to show stop/reload button. Also if focus if on url bar and if user press reload button then page is reloaded and suggestion popup appears with page load which is not correct. BUG= Committed: https://crrev.com/8dfbf87e5975b82a20147bd57df21adbb01ce0fb Cr-Commit-Position: refs/heads/master@{#301602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ankit
@Bernhard PTAL
6 years, 1 month ago (2014-10-28 11:07:49 UTC) #2
Bernhard Bauer
lgtm
6 years, 1 month ago (2014-10-28 11:08:55 UTC) #3
ankit
On 2014/10/28 11:08:55, Bernhard Bauer wrote: > lgtm Thanks.
6 years, 1 month ago (2014-10-28 11:09:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680293002/1
6 years, 1 month ago (2014-10-28 11:11:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 11:56:56 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 11:57:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dfbf87e5975b82a20147bd57df21adbb01ce0fb
Cr-Commit-Position: refs/heads/master@{#301602}

Powered by Google App Engine
This is Rietveld 408576698