Issue 680283002: Fix assertion scope in Runtime_GetScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 680283002: Fix assertion scope in Runtime_GetScript. (Closed)

Created:
6 years, 1 month ago by Yang

Modified:
6 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix assertion scope in Runtime_GetScript. The HeapIterator implies DisallowHeapAllocation, but Script::GetWrapper may allocate. LOG=N R=jkummerow@chromium.org BUG=chromium:410033 Committed: https://code.google.com/p/v8/source/detail?r=25001

Patch Set 2 : addressed comment #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -41 lines)			Patch
	M	src/runtime/runtime-debug.cc	View		1 chunk	+19 lines, -37 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-410033.js	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://codereview.chromium.org/680283002/diff/1/test/mjsunit/regress/regress-crbug-410033.js File test/mjsunit/regress/regress-crbug-410033.js (right): https://codereview.chromium.org/680283002/diff/1/test/mjsunit/regress/regress-crbug-410033.js#newcode1 test/mjsunit/regress/regress-crbug-410033.js:1: // Copyright 2012 the V8 project authors. All ...

6 years, 1 month ago (2014-10-29 11:54:52 UTC) #2

Yang

6 years, 1 month ago (2014-10-30 07:25:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 25001 (presubmit successful).

Expand Messages | Collapse Messages

Issue 680283002: Fix assertion scope in Runtime_GetScript. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment #

Messages