Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 680243002: Use OSMesa when running Sky tests (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn, ojan
CC:
ojan, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Use OSMesa when running Sky tests This CL switches us to use OSMesa rather than the system GL implementation when running the Sky tests. This makes the tests more machine-independent and also makes them work properly in Chromoting and in VirtualBox. R=ojan@chromium.org, esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/895f5c85943f9f645139043f7573a5e66f8c452f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sky/tools/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-28 03:42:08 UTC) #1
ojan
lgtm
6 years, 1 month ago (2014-10-28 03:43:19 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-28 03:44:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
895f5c85943f9f645139043f7573a5e66f8c452f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698