Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 680213003: Cleanup: Remove most enable_extensions logic in chrome/ extensions code. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
palmer, Yoyo Zhou, dcheng
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove most enable_extensions logic in chrome/ extensions code. They are no longer needed since nearly no extensions code gets built when extensions are disabled. Committed: https://crrev.com/a52fbd252fdaea6395a31e6336608c3b26794aaa Cr-Commit-Position: refs/heads/master@{#302244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -81 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/api_registration.gyp View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/common_message_generator.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/schemas.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 chunk +14 lines, -25 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 6 chunks +3 lines, -20 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/chrome_utility_extensions_messages.h View 5 chunks +0 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/extension_frame_helper.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Lei Zhang
6 years, 1 month ago (2014-10-28 06:27:07 UTC) #2
Yoyo Zhou
LGTM!
6 years, 1 month ago (2014-10-28 21:56:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680213003/1
6 years, 1 month ago (2014-10-28 22:44:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20731)
6 years, 1 month ago (2014-10-28 22:51:24 UTC) #7
Lei Zhang
+dcheng for chrome_utility_extensions_messages.h
6 years, 1 month ago (2014-10-28 22:56:26 UTC) #9
Lei Zhang
trying another IPC reviewer
6 years, 1 month ago (2014-10-31 05:43:18 UTC) #11
dcheng
rslgtm for IPC changes. Sorry for missing this (please feel free to ping me on ...
6 years, 1 month ago (2014-10-31 07:43:56 UTC) #12
dcheng
rs lgtm. argh.
6 years, 1 month ago (2014-10-31 07:44:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680213003/1
6 years, 1 month ago (2014-10-31 08:28:41 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 09:01:58 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 09:02:33 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a52fbd252fdaea6395a31e6336608c3b26794aaa
Cr-Commit-Position: refs/heads/master@{#302244}

Powered by Google App Engine
This is Rietveld 408576698