IDL: Generate union type containers

Source/bindings/modules/v8/generated.gyp

Index: Source/bindings/modules/v8/generated.gyp
diff --git a/Source/bindings/modules/v8/generated.gyp b/Source/bindings/modules/v8/generated.gyp
index c9237b54d70688f28f621c0533570197605cae19..b6ae2609e0e4862a5ede3746fa2569f582338617 100644
--- a/Source/bindings/modules/v8/generated.gyp
+++ b/Source/bindings/modules/v8/generated.gyp
@@ -109,23 +109,24 @@
   },
 ################################################################################
   {
-    # GN version: //third_party/WebKit/Source/bindings/modules/v8:bindings_modules_dictionary_impl_generated
+    # GN version: //third_party/WebKit/Source/bindings/modules/v8:bindings_modules_impl_generated
     # http://crbug.com/358074; See comments on
     # 'bindings_core_v8_generated_individual' target
-    'target_name': 'bindings_modules_dictionary_impl_generated',
+    'target_name': 'bindings_modules_impl_generated',
     'type': 'none',
     'hard_dependency': 1,
     'dependencies': [
       '<(bindings_scripts_dir)/scripts.gyp:cached_jinja_templates',
       '<(bindings_scripts_dir)/scripts.gyp:cached_lex_yacc_tables',
       '../../modules/generated.gyp:interfaces_info',
+      '../../modules/generated.gyp:interfaces_info_individual_modules',
     ],
     'sources': [
       '<@(modules_dictionary_idl_files)',
     ],
     'actions': [{
       'action_name': 'idl_dictionary',
-      # See comment on bindings_core_dictionary_impl_generated
+      # See comment on bindings_core_impl_generated
       'explicit_idl_action': 1,
       'msvs_cygwin_shell': 0,
       'inputs': [
@@ -135,8 +136,10 @@
         '<@(idl_compiler_files)',
         '<(bindings_dir)/IDLExtendedAttributes.txt',
         '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+        '<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
       ],
       'outputs': [
+        '<@(bindings_modules_v8_generated_union_type_files)',
         '<@(generated_modules_dictionary_files)',
       ],
       'action': [
@@ -145,12 +148,18 @@
         '--cache-dir',
         '<(bindings_scripts_output_dir)',
         '--output-dir',
+        '<(bindings_modules_v8_output_dir)',
+        '--dictionary-impl-output-dir',
         '<(SHARED_INTERMEDIATE_DIR)/blink/',

[haraken, 2014/10/29 04:59:29]

Just help me understand: Why do we need a different directory for --output-dir
and --dictionary-impl-output-dir?

[bashi, 2014/10/29 09:57:36]

Dictionary impls are generated under gen/blink/{core,modules}/foo/bar (e.g.
core/dom/DOMPoint.idl -> gen/blink/core/dom/DOMPoint.{cpp,h}).

Union types are generated under
gen/blink/bindings/{core,modules}/v8/UnionTypes{Core,Modules}.{cpp,h}

We can just pass 'gen/blink' as --output-dir, but this I don't think it is a
good idea because we need to generate something the same as
"bindings_modules_v8_output_dir" in idl_compiler.py. This means we will have two
places to define the directory path.

         '--interfaces-info',
         '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+        '--individual-info',
+        '<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',

[haraken, 2014/10/29 04:59:29]

Hmm, "InterfacesInfoModulesIndividual" is a bit confusing. This is not a pickle
that contains information of each individual interface...

It should be something like "OtherInfoForModules", although we want to avoid
"Other". What information will be put into the pickle file other than union
types?

[bashi, 2014/10/29 09:57:36]

Hmm, in fact, we already put global information into the pickle
file('partial_interface_files'). Anyway, added new pickle files for storing
component-wide information.

+        '--target-component',
+        'modules',
         '--write-file-only-if-changed',
         '<(write_file_only_if_changed)',
-        '--generate-dictionary-impl',
+        '--generate-impl',
         '<(modules_dictionary_idl_files_list)',
       ],
       'message': 'Generating modules IDL dictionary impl classes',
@@ -281,7 +290,7 @@
     'target_name': 'bindings_modules_v8_generated',
     'type': 'none',
     'dependencies': [
-      'bindings_modules_dictionary_impl_generated',
+      'bindings_modules_impl_generated',
       'bindings_modules_v8_generated_aggregate',
       'bindings_modules_v8_generated_individual',
       'bindings_modules_v8_generated_init_partial',