Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: Source/core/animation/AnimationNodeTiming.cpp

Issue 680193003: IDL: Generate union type containers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/AnimationNodeTiming.cpp
diff --git a/Source/core/animation/AnimationNodeTiming.cpp b/Source/core/animation/AnimationNodeTiming.cpp
index 9c34d7a49cb84c75eba4ef4a26ba154437e3cae5..20ad3ea99acdb569bed97a3f3178e001bc04b73c 100644
--- a/Source/core/animation/AnimationNodeTiming.cpp
+++ b/Source/core/animation/AnimationNodeTiming.cpp
@@ -5,6 +5,7 @@
#include "config.h"
#include "core/animation/AnimationNodeTiming.h"
+#include "bindings/core/v8/UnionTypesCore.h"
#include "core/animation/Animation.h"
#include "core/animation/AnimationNode.h"
#include "platform/animation/TimingFunction.h"
@@ -64,16 +65,17 @@ double AnimationNodeTiming::iterations()
// and bindings/tests/results/V8TestInterface.cpp.
// FIXME: It might be possible to have 'duration' defined as an attribute in the idl.
// If possible, fix will be in a follow-up patch.
-void AnimationNodeTiming::getDuration(String propertyName, Nullable<double>& element0, String& element1)
+// http://crbug.com/240176
+void AnimationNodeTiming::getDuration(String propertyName, DoubleOrString& returnValue)
{
if (propertyName != "duration")
return;
if (std::isnan(m_parent->specifiedTiming().iterationDuration)) {
- element1 = "auto";
+ returnValue.setString("auto");
return;
}
- element0.set(m_parent->specifiedTiming().iterationDuration * 1000);
+ returnValue.setDouble(m_parent->specifiedTiming().iterationDuration * 1000);
return;
}

Powered by Google App Engine
This is Rietveld 408576698