IDL: Generate union type containers

Source/bindings/modules/v8/generated.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Generate IDL bindings for modules, plus aggregate bindings files.
 #
 # Design doc: http://www.chromium.org/developers/design-documents/idl-build
 
 {
   'includes': [
@@ skipping 91 matching lines @@
         'modules',
         '<(modules_idl_files_list)',
         '--',
         '<@(bindings_modules_v8_generated_aggregate_files)',
       ],
       'message': 'Generating aggregate generated modules V8 bindings files',
     }],
   },
 ################################################################################
   {
-    # GN version: //third_party/WebKit/Source/bindings/modules/v8:bindings_modules_dictionary_impl_generated
+    # GN version: //third_party/WebKit/Source/bindings/modules/v8:bindings_modules_impl_generated
     # http://crbug.com/358074; See comments on
     # 'bindings_core_v8_generated_individual' target
-    'target_name': 'bindings_modules_dictionary_impl_generated',
+    'target_name': 'bindings_modules_impl_generated',
     'type': 'none',
     'hard_dependency': 1,
     'dependencies': [
       '<(bindings_scripts_dir)/scripts.gyp:cached_jinja_templates',
       '<(bindings_scripts_dir)/scripts.gyp:cached_lex_yacc_tables',
       '../../modules/generated.gyp:interfaces_info',
+      '../../modules/generated.gyp:interfaces_info_individual_modules',
     ],
     'sources': [
       '<@(modules_dictionary_idl_files)',
     ],
     'actions': [{
       'action_name': 'idl_dictionary',
-      # See comment on bindings_core_dictionary_impl_generated
+      # See comment on bindings_core_impl_generated
       'explicit_idl_action': 1,
       'msvs_cygwin_shell': 0,
       'inputs': [
         '<@(modules_dictionary_idl_files)',
         '<@(idl_lexer_parser_files)',
         '<@(idl_cache_files)',
         '<@(idl_compiler_files)',
         '<(bindings_dir)/IDLExtendedAttributes.txt',
         '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+        '<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
       ],
       'outputs': [
+        '<@(bindings_modules_v8_generated_union_type_files)',
         '<@(generated_modules_dictionary_files)',
       ],
       'action': [
         'python',
         '<(bindings_scripts_dir)/idl_compiler.py',
         '--cache-dir',
         '<(bindings_scripts_output_dir)',
         '--output-dir',
+        '<(bindings_modules_v8_output_dir)',
+        '--dictionary-impl-output-dir',
         '<(SHARED_INTERMEDIATE_DIR)/blink/',

[haraken, 2014/10/29 04:59:29]

Just help me understand: Why do we need a different directory for --output-dir
and --dictionary-impl-output-dir?

[bashi, 2014/10/29 09:57:36]

Dictionary impls are generated under gen/blink/{core,modules}/foo/bar (e.g.
core/dom/DOMPoint.idl -> gen/blink/core/dom/DOMPoint.{cpp,h}).

Union types are generated under
gen/blink/bindings/{core,modules}/v8/UnionTypes{Core,Modules}.{cpp,h}

We can just pass 'gen/blink' as --output-dir, but this I don't think it is a
good idea because we need to generate something the same as
"bindings_modules_v8_output_dir" in idl_compiler.py. This means we will have two
places to define the directory path.

         '--interfaces-info',
         '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+        '--individual-info',
+        '<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',

[haraken, 2014/10/29 04:59:29]

Hmm, "InterfacesInfoModulesIndividual" is a bit confusing. This is not a pickle
that contains information of each individual interface...

It should be something like "OtherInfoForModules", although we want to avoid
"Other". What information will be put into the pickle file other than union
types?

[bashi, 2014/10/29 09:57:36]

Hmm, in fact, we already put global information into the pickle
file('partial_interface_files'). Anyway, added new pickle files for storing
component-wide information.

+        '--target-component',
+        'modules',
         '--write-file-only-if-changed',
         '<(write_file_only_if_changed)',
-        '--generate-dictionary-impl',
+        '--generate-impl',
         '<(modules_dictionary_idl_files_list)',
       ],
       'message': 'Generating modules IDL dictionary impl classes',
     }],
   },
 ################################################################################
   {
     'target_name': 'bindings_modules_v8_generated_partial_individual',
     'type': 'none',
     # The 'partial_binding' rule generates .h files, so mark as hard_dependency, per:
@@ skipping 110 matching lines @@
         '--write-file-only-if-changed',
         '<(write_file_only_if_changed)',
       ],
     }],
   },
 ################################################################################
   {
     'target_name': 'bindings_modules_v8_generated',
     'type': 'none',
     'dependencies': [
-      'bindings_modules_dictionary_impl_generated',
+      'bindings_modules_impl_generated',
       'bindings_modules_v8_generated_aggregate',
       'bindings_modules_v8_generated_individual',
       'bindings_modules_v8_generated_init_partial',
       'bindings_modules_v8_generated_partial_aggregate',
       'bindings_modules_v8_generated_partial_individual',
     ],
   },
 ################################################################################
   ],  # targets
 }