IDL: Generate union type containers

Source/bindings/scripts/compute_interfaces_info_individual.py

 #!/usr/bin/python
 #
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 179 matching lines @@
         elif definitions.dictionaries:
             definition = next(definitions.dictionaries.itervalues())
             interface_info = {
                 'is_callback_interface': False,
                 'is_dictionary': True,
                 'referenced_interfaces': None,
             }
         else:
             raise Exception('IDL file must contain one interface or dictionary')
 
-        self.union_types.update(
-            collect_union_types_from_definitions(definitions))
+        this_union_types = collect_union_types_from_definitions(definitions)
+        self.union_types.update(this_union_types)
 
         extended_attributes = definition.extended_attributes
         implemented_as = extended_attributes.get('ImplementedAs')
         full_path = os.path.realpath(idl_filename)
         this_include_path = None if 'NoImplHeader' in extended_attributes else include_path(idl_filename, implemented_as)
         if definition.is_partial:
             # We don't create interface_info for partial interfaces, but
             # adds paths to another dict.
             self.add_paths_to_partials_dict(definition.name, full_path, this_include_path)
             return
 
         # 'implements' statements can be included in either the file for the
         # implement*ing* interface (lhs of 'implements') or implement*ed* interface
         # (rhs of 'implements'). Store both for now, then merge to implement*ing*
         # interface later.
         left_interfaces, right_interfaces = get_implements_from_definitions(
             definitions, definition.name)
 
         interface_info.update({
             'extended_attributes': extended_attributes,
             'full_path': full_path,
+            'has_union_types': len(this_union_types) > 0,  # explicit len(...) > 0 to convert boolean

[Jens Widell, 2014/10/28 11:31:37]

Another way of explicitly converting to bool would be "bool(this_union_types)".
A bit better, I think; calculating the length of something for comparison to
zero is a classic anti-pattern.

[bashi, 2014/10/29 01:34:32]

Definitely better way:) Done.

             'implemented_as': implemented_as,
             'implemented_by_interfaces': left_interfaces,
             'implements_interfaces': right_interfaces,
             'include_path': this_include_path,
             # FIXME: temporary private field, while removing old treatement of
             # 'implements': http://crbug.com/360435
             'is_legacy_treat_as_partial_interface': 'LegacyTreatAsPartialInterface' in extended_attributes,
             'parent': definition.parent,
             'relative_dir': relative_dir_posix(idl_filename),
         })
@@ skipping 29 matching lines @@
     for idl_filename in idl_files:
         info_collector.collect_info(idl_filename)
 
     write_pickle_file(options.interfaces_info_file,
                       info_collector.get_info_as_dict(),
                       options.write_file_only_if_changed)
 
 
 if __name__ == '__main__':
     sys.exit(main())