Plugin Power Saver: Implement size-based heuristic for peripheral content.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 475 matching lines @@
   // stored in render_(view|frame)_message_source_.
   if (render_frame_host)
     render_frame_message_source_ = render_frame_host;
   else
     render_view_message_source_ = render_view_host;
 
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(WebContentsImpl, message)
     IPC_MESSAGE_HANDLER(FrameHostMsg_PepperPluginHung, OnPepperPluginHung)
     IPC_MESSAGE_HANDLER(FrameHostMsg_PluginCrashed, OnPluginCrashed)
+    IPC_MESSAGE_HANDLER(FrameHostMsg_PluginContentOriginAllowed,
+                        OnPluginContentOriginAllowed)
+    IPC_MESSAGE_HANDLER(FrameHostMsg_PluginContentMarkedPeripheral,
+                        OnPluginContentMarkedPeripheral)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DomOperationResponse,
                         OnDomOperationResponse)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidChangeThemeColor,
                         OnThemeColorChanged)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidFinishDocumentLoad,
                         OnDocumentLoadedInFrame)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidFinishLoad, OnDidFinishLoad)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidStartLoading, OnDidStartLoading)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidStopLoading, OnDidStopLoading)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidChangeLoadProgress,
@@ skipping 2386 matching lines @@
   FOR_EACH_OBSERVER(WebContentsObserver, observers_,
                     PluginHungStatusChanged(plugin_child_id, path, is_hung));
 }
 
 void WebContentsImpl::OnPluginCrashed(const base::FilePath& plugin_path,
                                       base::ProcessId plugin_pid) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_,
                     PluginCrashed(plugin_path, plugin_pid));
 }
 
+void WebContentsImpl::OnPluginContentOriginAllowed(const GURL& content_origin) {
+  DCHECK(render_frame_message_source_);
+  DCHECK(!render_view_message_source_);
+
+  plugin_content_origin_whitelist_[render_frame_message_source_].insert(

[groby-ooo-7-16, 2014/10/28 00:39:12]

Why is this a map keyed by renderframe? AFAICT, we never look up by frame and
always traverse the whole thing?

[Lei Zhang, 2014/10/28 02:16:23]

I think it's just being used to limit the number of RenderFrames we send IPCs
to. I guess this all depends on how costly it is to broadcast to all frames. jam
or nasko can probably tell you? If we do end up broadcasting to all frames, we
probably don't need FrameHostMsg_PluginContentMarkedPeripheral.

+      content_origin);
+
+  // Broadcast whitelisting to all render frames with plugin content from this
+  // origin thas has already been marked peripheral.
+  for (auto peripheral_plugin_origins : plugin_content_marked_peripheral_) {
+    if (peripheral_plugin_origins.second.erase(content_origin) > 0) {

[groby-ooo-7-16, 2014/10/28 00:39:11]

Hm. Is that necessary? The message is broadcast anyways, can we just send it to
all renderframes? Or is that cost-prohibitive?

If it is: It feels like the set of plugin origins should be stored per frame,
not on WebContents. We only need WebContents for the document-wide whitelist,
right?

[tommycli, 2014/10/28 22:18:07]

The WebContents needs to aggregate all the per-frame whitelists to send to all
the RenderFrames.

+      Send(new FrameMsg_PluginContentOriginWhitelisted(
+          peripheral_plugin_origins.first->GetRoutingID(),
+          content_origin));
+    }
+  }
+}
+
+void WebContentsImpl::OnPluginContentMarkedPeripheral(
+    const GURL& content_origin) {
+  DCHECK(render_frame_message_source_);
+  DCHECK(!render_view_message_source_);
+
+  bool origin_already_whitelisted = false;
+  for (auto whitelisted_plugin_origins : plugin_content_origin_whitelist_) {
+    if (whitelisted_plugin_origins.second.find(content_origin) !=

[groby-ooo-7-16, 2014/10/28 00:39:11]

Since you're just checking for set membership: 

if (whitelisted_plugin_origins.count(content_origin)) {
 ...
}

does the same, but is shorter.

[tommycli, 2014/10/28 22:18:07]

Done.

+        whitelisted_plugin_origins.second.end()) {
+      origin_already_whitelisted = true;
+      break;
+    }
+  }
+
+  if (origin_already_whitelisted) {
+    Send(new FrameMsg_PluginContentOriginWhitelisted(
+        render_frame_message_source_->GetRoutingID(),
+        content_origin));
+  } else {
+    plugin_content_marked_peripheral_[render_frame_message_source_].insert(
+        content_origin);
+  }
+}
+
 void WebContentsImpl::OnDomOperationResponse(const std::string& json_string,
                                              int automation_id) {
   DomOperationNotificationDetails details(json_string, automation_id);
   NotificationService::current()->Notify(
       NOTIFICATION_DOM_OPERATION_RESPONSE,
       Source<WebContents>(this),
       Details<DomOperationNotificationDetails>(&details));
 }
 
 void WebContentsImpl::OnAppCacheAccessed(const GURL& manifest_url,
@@ skipping 417 matching lines @@
   // Note this is only for subframes, the notification for the main frame
   // happens in RenderViewCreated.
   FOR_EACH_OBSERVER(WebContentsObserver,
                     observers_,
                     RenderFrameCreated(render_frame_host));
   SetAccessibilityModeOnFrame(accessibility_mode_, render_frame_host);
 }
 
 void WebContentsImpl::RenderFrameDeleted(RenderFrameHost* render_frame_host) {
   ClearPowerSaveBlockers(render_frame_host);
+  plugin_content_origin_whitelist_.erase(render_frame_host);
+  plugin_content_marked_peripheral_.erase(render_frame_host);
   FOR_EACH_OBSERVER(WebContentsObserver,
                     observers_,
                     RenderFrameDeleted(render_frame_host));
 }
 
 void WebContentsImpl::WorkerCrashed(RenderFrameHost* render_frame_host) {
   if (delegate_)
     delegate_->WorkerCrashed(this);
 }
 
@@ skipping 976 matching lines @@
   node->render_manager()->ResumeResponseDeferredAtStart();
 }
 
 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
   force_disable_overscroll_content_ = force_disable;
   if (view_)
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
 }  // namespace content