Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 680173003: Improve branch creation in release scripts. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Improve branch creation in release scripts. Use 'git new-branch' for creating new branches. BUG=410721 LOG=n TEST=script_test.py R=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M tools/push-to-trunk/git_recipes.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 11 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
PTAL
6 years, 1 month ago (2014-10-28 10:27:12 UTC) #2
tandrii(chromium)
lgtm
6 years, 1 month ago (2014-10-28 10:44:20 UTC) #3
Michael Achenbach
Committed patchset #1 (id:1) manually as 24940 (presubmit successful).
6 years, 1 month ago (2014-10-28 13:43:13 UTC) #4
agable
6 years, 1 month ago (2014-10-30 18:56:31 UTC) #5
Message was sent while issue was closed.
On 2014/10/28 13:43:13, Michael Achenbach wrote:
> Committed patchset #1 (id:1) manually as 24940 (presubmit successful).

lgtm2

Powered by Google App Engine
This is Rietveld 408576698