Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 680173002: Remove HTML entity crazy (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove HTML entity crazy This CL removes the bulk of the old HTML entity machinery. We don't need this anymore. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/12efa5507268588e7bb22ca530373d358051d17b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2752 lines) Patch
M sky/engine/core/BUILD.gn View 3 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/engine/core/html/parser/HTMLEntityNames.in View 1 chunk +0 lines, -2231 lines 0 comments Download
D sky/engine/core/html/parser/HTMLEntitySearch.h View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/engine/core/html/parser/HTMLEntitySearch.cpp View 1 chunk +0 lines, -128 lines 0 comments Download
D sky/engine/core/html/parser/HTMLEntityTable.h View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/engine/core/html/parser/create-html-entity-table View 1 chunk +0 lines, -242 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-27 22:43:17 UTC) #1
eseidel
lgtm So do we have named entities at all?
6 years, 1 month ago (2014-10-27 23:52:23 UTC) #2
abarth-chromium
On 2014/10/27 at 23:52:23, eseidel wrote: > lgtm > > So do we have named ...
6 years, 1 month ago (2014-10-28 00:01:05 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-10-28 00:05:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12efa5507268588e7bb22ca530373d358051d17b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698