Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: ash/root_window_controller_unittest.cc

Issue 680153002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/root_window_controller_unittest.cc
diff --git a/ash/root_window_controller_unittest.cc b/ash/root_window_controller_unittest.cc
index 4d7a0862d8095d4b62d8339bff81ad4d46ea7f37..59e9c43889a439f6d16ee3b4e2c1a0055bc51fbf 100644
--- a/ash/root_window_controller_unittest.cc
+++ b/ash/root_window_controller_unittest.cc
@@ -48,14 +48,12 @@ namespace {
class TestDelegate : public views::WidgetDelegateView {
public:
explicit TestDelegate(bool system_modal) : system_modal_(system_modal) {}
- virtual ~TestDelegate() {}
+ ~TestDelegate() override {}
// Overridden from views::WidgetDelegate:
- virtual views::View* GetContentsView() override {
- return this;
- }
+ views::View* GetContentsView() override { return this; }
- virtual ui::ModalType GetModalType() const override {
+ ui::ModalType GetModalType() const override {
return system_modal_ ? ui::MODAL_TYPE_SYSTEM : ui::MODAL_TYPE_NONE;
}
@@ -69,7 +67,7 @@ class DeleteOnBlurDelegate : public aura::test::TestWindowDelegate,
public aura::client::FocusChangeObserver {
public:
DeleteOnBlurDelegate() : window_(NULL) {}
- virtual ~DeleteOnBlurDelegate() {}
+ ~DeleteOnBlurDelegate() override {}
void SetWindow(aura::Window* window) {
window_ = window;
@@ -78,13 +76,11 @@ class DeleteOnBlurDelegate : public aura::test::TestWindowDelegate,
private:
// aura::test::TestWindowDelegate overrides:
- virtual bool CanFocus() override {
- return true;
- }
+ bool CanFocus() override { return true; }
// aura::client::FocusChangeObserver implementation:
- virtual void OnWindowFocused(aura::Window* gained_focus,
- aura::Window* lost_focus) override {
+ void OnWindowFocused(aura::Window* gained_focus,
+ aura::Window* lost_focus) override {
if (window_ == lost_focus)
delete window_;
}
@@ -526,9 +522,7 @@ TEST_F(RootWindowControllerTest, FocusBlockedWindow) {
class DestroyedWindowObserver : public aura::WindowObserver {
public:
DestroyedWindowObserver() : destroyed_(false), window_(NULL) {}
- virtual ~DestroyedWindowObserver() {
- Shutdown();
- }
+ ~DestroyedWindowObserver() override { Shutdown(); }
void SetWindow(Window* window) {
window_ = window;
@@ -538,7 +532,7 @@ class DestroyedWindowObserver : public aura::WindowObserver {
bool destroyed() const { return destroyed_; }
// WindowObserver overrides:
- virtual void OnWindowDestroying(Window* window) override {
+ void OnWindowDestroying(Window* window) override {
destroyed_ = true;
Shutdown();
}
@@ -615,9 +609,9 @@ class VirtualKeyboardRootWindowControllerTest
: public RootWindowControllerTest {
public:
VirtualKeyboardRootWindowControllerTest() {};
- virtual ~VirtualKeyboardRootWindowControllerTest() {};
+ ~VirtualKeyboardRootWindowControllerTest() override{};
Daniel Erat 2014/10/27 21:55:49 nit: override {}
dcheng 2014/10/27 22:03:41 Fixed this one too.
- virtual void SetUp() override {
+ void SetUp() override {
CommandLine::ForCurrentProcess()->AppendSwitch(
keyboard::switches::kEnableVirtualKeyboard);
test::AshTestBase::SetUp();
@@ -634,7 +628,7 @@ class MockTextInputClient : public ui::DummyTextInputClient {
MockTextInputClient() :
ui::DummyTextInputClient(ui::TEXT_INPUT_TYPE_TEXT) {}
- virtual void EnsureCaretInRect(const gfx::Rect& rect) override {
+ void EnsureCaretInRect(const gfx::Rect& rect) override {
visible_rect_ = rect;
}
@@ -653,7 +647,7 @@ class TargetHitTestEventHandler : public ui::test::TestEventHandler {
TargetHitTestEventHandler() {}
// ui::test::TestEventHandler overrides.
- virtual void OnMouseEvent(ui::MouseEvent* event) override {
+ void OnMouseEvent(ui::MouseEvent* event) override {
if (event->type() == ui::ET_MOUSE_PRESSED)
ui::test::TestEventHandler::OnMouseEvent(event);
event->StopPropagation();

Powered by Google App Engine
This is Rietveld 408576698