Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4162)

Unified Diff: chrome/browser/ui/views/web_dialog_view_browsertest.cc

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/web_dialog_view_browsertest.cc
diff --git a/chrome/browser/ui/views/web_dialog_view_browsertest.cc b/chrome/browser/ui/views/web_dialog_view_browsertest.cc
index d74c9562ca5deb585430ffb27bae64c83c958c85..779bb588a40f04cdf55bd6676e3ce3a53d4495ca 100644
--- a/chrome/browser/ui/views/web_dialog_view_browsertest.cc
+++ b/chrome/browser/ui/views/web_dialog_view_browsertest.cc
@@ -50,8 +50,8 @@ class TestWebDialogView : public views::WebDialogView {
private:
// TODO(xiyuan): Update this when WidgetDelegate has bounds change hook.
- virtual void SaveWindowPlacement(const gfx::Rect& bounds,
- ui::WindowShowState show_state) override {
+ void SaveWindowPlacement(const gfx::Rect& bounds,
+ ui::WindowShowState show_state) override {
if (should_quit_on_size_change_ && last_size_ != bounds.size()) {
// Schedule message loop quit because we could be called while
// the bounds change call is on the stack and not in the nested message
@@ -65,7 +65,7 @@ class TestWebDialogView : public views::WebDialogView {
last_size_ = bounds.size();
}
- virtual void OnDialogClosed(const std::string& json_retval) override {
+ void OnDialogClosed(const std::string& json_retval) override {
should_quit_on_size_change_ = false; // No quit when we are closing.
views::WebDialogView::OnDialogClosed(json_retval);
}
« no previous file with comments | « chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698