Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6351)

Unified Diff: chrome/browser/ui/views/login_prompt_views.cc

Issue 680133002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/load_complete_listener.h ('k') | chrome/browser/ui/views/login_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/login_prompt_views.cc
diff --git a/chrome/browser/ui/views/login_prompt_views.cc b/chrome/browser/ui/views/login_prompt_views.cc
index 1607dff9cbcd57bf7398c3054cd8c17e97b45892..36a15413a068e267b4d03f7a6ecb8f059735dec6 100644
--- a/chrome/browser/ui/views/login_prompt_views.cc
+++ b/chrome/browser/ui/views/login_prompt_views.cc
@@ -34,26 +34,24 @@ class LoginHandlerViews : public LoginHandler, public views::DialogDelegate {
}
// LoginModelObserver:
- virtual void OnAutofillDataAvailable(
- const base::string16& username,
- const base::string16& password) override {
+ void OnAutofillDataAvailable(const base::string16& username,
+ const base::string16& password) override {
// Nothing to do here since LoginView takes care of autofill for win.
}
- virtual void OnLoginModelDestroying() override {}
+ void OnLoginModelDestroying() override {}
// views::DialogDelegate:
- virtual base::string16 GetDialogButtonLabel(
- ui::DialogButton button) const override {
+ base::string16 GetDialogButtonLabel(ui::DialogButton button) const override {
if (button == ui::DIALOG_BUTTON_OK)
return l10n_util::GetStringUTF16(IDS_LOGIN_DIALOG_OK_BUTTON_LABEL);
return DialogDelegate::GetDialogButtonLabel(button);
}
- virtual base::string16 GetWindowTitle() const override {
+ base::string16 GetWindowTitle() const override {
return l10n_util::GetStringUTF16(IDS_LOGIN_DIALOG_TITLE);
}
- virtual void WindowClosing() override {
+ void WindowClosing() override {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
content::WebContents* web_contents = GetWebContentsForLogin();
if (web_contents)
@@ -64,7 +62,7 @@ class LoginHandlerViews : public LoginHandler, public views::DialogDelegate {
CancelAuth();
}
- virtual void DeleteDelegate() override {
+ void DeleteDelegate() override {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
// The widget is going to delete itself; clear our pointer.
@@ -74,40 +72,33 @@ class LoginHandlerViews : public LoginHandler, public views::DialogDelegate {
ReleaseSoon();
}
- virtual ui::ModalType GetModalType() const override {
- return ui::MODAL_TYPE_CHILD;
- }
+ ui::ModalType GetModalType() const override { return ui::MODAL_TYPE_CHILD; }
- virtual bool Cancel() override {
+ bool Cancel() override {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
CancelAuth();
return true;
}
- virtual bool Accept() override {
+ bool Accept() override {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
SetAuth(login_view_->GetUsername(), login_view_->GetPassword());
return true;
}
- virtual views::View* GetInitiallyFocusedView() override {
+ views::View* GetInitiallyFocusedView() override {
return login_view_->GetInitiallyFocusedView();
}
- virtual views::View* GetContentsView() override {
- return login_view_;
- }
- virtual views::Widget* GetWidget() override {
- return login_view_->GetWidget();
- }
- virtual const views::Widget* GetWidget() const override {
+ views::View* GetContentsView() override { return login_view_; }
+ views::Widget* GetWidget() override { return login_view_->GetWidget(); }
+ const views::Widget* GetWidget() const override {
return login_view_->GetWidget();
}
// LoginHandler:
- virtual void BuildViewForPasswordManager(
- password_manager::PasswordManager* manager,
- const base::string16& explanation) override {
+ void BuildViewForPasswordManager(password_manager::PasswordManager* manager,
+ const base::string16& explanation) override {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
// Create a new LoginView and set the model for it. The model (password
@@ -126,7 +117,7 @@ class LoginHandlerViews : public LoginHandler, public views::DialogDelegate {
NotifyAuthNeeded();
}
- virtual void CloseDialog() override {
+ void CloseDialog() override {
// The hosting widget may have been freed.
if (dialog_)
dialog_->Close();
@@ -136,7 +127,7 @@ class LoginHandlerViews : public LoginHandler, public views::DialogDelegate {
friend class base::RefCountedThreadSafe<LoginHandlerViews>;
friend class LoginPrompt;
- virtual ~LoginHandlerViews() {}
+ ~LoginHandlerViews() override {}
// The LoginView that contains the user's login information.
LoginView* login_view_;
« no previous file with comments | « chrome/browser/ui/views/load_complete_listener.h ('k') | chrome/browser/ui/views/login_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698