Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 6801054: Adding class WebWavSoundResource, downloads and decode wav audio data from a URL. Implements the (Closed)

Created:
9 years, 8 months ago by gwink1
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Adding class WebWavSoundResource, downloads and decode wav audio data from a URL. Implements the WebResourceLoader::Delegate methods to plug into that class. Committed: http://code.google.com/p/nativeclient/source/detail?r=241

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -0 lines) Patch
A experimental/life2011/life_stage_5/web_wav_sound_resource.h View 1 1 chunk +64 lines, -0 lines 0 comments Download
A experimental/life2011/life_stage_5/web_wav_sound_resource.cc View 1 1 chunk +204 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
gwink1
Here's class WebWavSoundResource. It's a delegate to WebResourceLoader. It aggregates the data chunks received from ...
9 years, 8 months ago (2011-04-07 20:00:50 UTC) #1
David Springer
LGTM
9 years, 8 months ago (2011-04-07 20:10:00 UTC) #2
bbudge
Several memory leak concerns. http://codereview.chromium.org/6801054/diff/1/experimental/life2011/life_stage_5/web_wav_sound_resource.cc File experimental/life2011/life_stage_5/web_wav_sound_resource.cc (right): http://codereview.chromium.org/6801054/diff/1/experimental/life2011/life_stage_5/web_wav_sound_resource.cc#newcode121 experimental/life2011/life_stage_5/web_wav_sound_resource.cc:121: loader->LoadURL(url); This looks like a ...
9 years, 8 months ago (2011-04-07 21:44:20 UTC) #3
gwink1
On 2011/04/07 20:10:00, David Springer wrote: > LGTM + bbudge@google.com I just realized I'm not ...
9 years, 8 months ago (2011-04-07 21:44:26 UTC) #4
bbudge
My previous comment should have been, 1 mem leak and potential access of deleted buffers.
9 years, 8 months ago (2011-04-07 21:46:01 UTC) #5
gwink1
http://codereview.chromium.org/6801054/diff/1/experimental/life2011/life_stage_5/web_wav_sound_resource.cc File experimental/life2011/life_stage_5/web_wav_sound_resource.cc (right): http://codereview.chromium.org/6801054/diff/1/experimental/life2011/life_stage_5/web_wav_sound_resource.cc#newcode121 experimental/life2011/life_stage_5/web_wav_sound_resource.cc:121: loader->LoadURL(url); On 2011/04/07 21:44:21, bbudge1 wrote: > This looks ...
9 years, 8 months ago (2011-04-08 16:33:16 UTC) #6
bbudge-google
9 years, 8 months ago (2011-04-08 17:08:29 UTC) #7
LGTM with a NULL check

http://codereview.chromium.org/6801054/diff/7001/experimental/life2011/life_s...
File experimental/life2011/life_stage_5/web_wav_sound_resource.cc (right):

http://codereview.chromium.org/6801054/diff/7001/experimental/life2011/life_s...
experimental/life2011/life_stage_5/web_wav_sound_resource.cc:200:
loader_->CloseAndDeleteSelf();
This needs a NULL check. Someone could instantiate and then immediately delete
an instance, causing a crash.

Powered by Google App Engine
This is Rietveld 408576698