Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issue 6801027: Standardize invocations of emerge in build_image (Closed)

Created:
9 years, 11 months ago by jrbarnette
Modified:
9 years, 9 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Standardize invocations of emerge in build_image. Also includes a style nit fix: don't quote arguments to numeric comparison test operators. BUG=chromium-os:13582 TEST=setup_board --force && build_packages && build_image; boot the result Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=eb5246f

Patch Set 1 #

Patch Set 2 : Style nit: don't quote arguments to numeric comparison tests #

Total comments: 8

Patch Set 3 : Tweak one emerge command #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -35 lines) Patch
M build_image View 1 2 12 chunks +28 lines, -35 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
jrbarnette
9 years, 11 months ago (2011-04-07 02:20:29 UTC) #1
jrbarnette
(added more reviewers) I only need one reviewer to step up. Anyone who's worried I ...
9 years, 11 months ago (2011-04-07 02:23:09 UTC) #2
davidjames
LGTM w/nits http://codereview.chromium.org/6801027/diff/1002/build_image File build_image (right): http://codereview.chromium.org/6801027/diff/1002/build_image#newcode211 build_image:211: emerge-${FLAGS_board} -uNDvg --binpkg-respect-use=y virtual/kernel --binpkg-respect-use=y is implied ...
9 years, 11 months ago (2011-04-07 06:32:18 UTC) #3
davidjames
http://codereview.chromium.org/6801027/diff/1002/build_image File build_image (right): http://codereview.chromium.org/6801027/diff/1002/build_image#newcode636 build_image:636: emerge_to_image --root="${ROOT_FS_DIR}" chromeos ${EXTRA_PACKAGES} On 2011/04/07 06:32:18, davidjames wrote: ...
9 years, 11 months ago (2011-04-07 06:41:18 UTC) #4
kliegs
I'd also like to see this tested by running through the buidlbot scripts (internal and ...
9 years, 11 months ago (2011-04-07 14:34:24 UTC) #5
jrbarnette
On 2011/04/07 14:34:24, kliegs wrote: > I'd also like to see this tested by running ...
9 years, 11 months ago (2011-04-07 19:06:35 UTC) #6
jrbarnette
http://codereview.chromium.org/6801027/diff/1002/build_image File build_image (right): http://codereview.chromium.org/6801027/diff/1002/build_image#newcode211 build_image:211: emerge-${FLAGS_board} -uNDvg --binpkg-respect-use=y virtual/kernel On 2011/04/07 06:32:18, davidjames wrote: ...
9 years, 11 months ago (2011-04-07 19:13:45 UTC) #7
kliegs
Ahh right. Sorry - I'd assumed both were coming in but USE can be null ...
9 years, 11 months ago (2011-04-07 19:14:23 UTC) #8
davidjames
http://codereview.chromium.org/6801027/diff/1002/build_image File build_image (right): http://codereview.chromium.org/6801027/diff/1002/build_image#newcode211 build_image:211: emerge-${FLAGS_board} -uNDvg --binpkg-respect-use=y virtual/kernel On 2011/04/07 19:13:45, jrbarnette wrote: ...
9 years, 11 months ago (2011-04-07 19:26:16 UTC) #9
zbehan
The only thing I'd be really careful about and has been mentioned here is that ...
9 years, 11 months ago (2011-04-07 19:49:34 UTC) #10
jrbarnette
I've updated the emerge command davidjames noted. I've asked sosa about the level of testing ...
9 years, 11 months ago (2011-04-07 22:29:52 UTC) #11
kliegs
If you've gone through it with sosa I'm not going to push for this to ...
9 years, 11 months ago (2011-04-07 22:42:08 UTC) #12
sosa
LGTM as well.
9 years, 11 months ago (2011-04-07 22:43:23 UTC) #13
zbehan
LGTM from me too. On Fri, Apr 8, 2011 at 12:43 AM, <sosa@chromium.org> wrote: > ...
9 years, 11 months ago (2011-04-07 22:50:01 UTC) #14
Vince Laviano
9 years, 11 months ago (2011-04-07 23:03:00 UTC) #15
On 2011/04/07 22:50:01, zbehan wrote:
> LGTM from me too.
> 
> On Fri, Apr 8, 2011 at 12:43 AM, <mailto:sosa@chromium.org> wrote:
> 
> > LGTM as well.
> >
> >
> > http://codereview.chromium.org/6801027/
> >

LGTM. (I think my world will remain unbroken.)

Powered by Google App Engine
This is Rietveld 408576698