[CSS Grid Layout] Redefining grids inside media queries does not work

[CSS Grid Layout] Redefining grids inside media queries does not work

So the problem is that in
StyleBuilderFunctions::applyValueCSSPropertyGridTemplateAreas we were assuming
that we were always getting a fresh RenderStyle, something that is not true,
because we might have overlapping declarations (multipled matching media
queries, user styles, etc).

As that function might be called multiple times, we need to properly regenerate
the list of named grid lines each time the function is called because the
NamedGridLinesMap returned by RenderStyle contains both the old explicit named
grid lines and the old implicit named grid lines.

BUG=427481
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185045

[svillar, 2014-10-28 15:34:32]

svillar@igalia.com changed reviewers:
+ eae@chromium.org, esprehn@chromium.org, jchaffraix@chromium.org

[svillar, 2014-11-10 14:42:04]

svillar@igalia.com changed reviewers:
- esprehn@chromium.org

[svillar, 2014-11-10 14:42:22]

On 2014/10/28 15:34:49, svillar wrote:

@jchaffraix: mind taking a look please?

[Julien - ping for review, 2014-11-10 16:03:32]

The CQ bit was checked by jchaffraix@chromium.org

[Julien - ping for review, 2014-11-10 16:03:33]

lgtm

https://codereview.chromium.org/680063005/diff/1/Source/core/css/resolver/Sty...
File Source/core/css/resolver/StyleBuilderConverter.cpp (right):

https://codereview.chromium.org/680063005/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StyleBuilderConverter.cpp:500:
std::sort(gridLineIndexes.begin(), gridLineIndexes.end());
We may know do 2 sorting as we generate the implicit named grid lines. We should
find a way to do only one per application. This is a nit though as I don't think
we will end up with a lot of tracks.

[commit-bot: I haz the power, 2014-11-10 16:03:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680063005/1

[Timothy Loh, 2014-11-10 16:07:41]

On 2014/10/28 15:34:49, svillar wrote:

FYI eventually (when I or someone else get's around to rebasing
https://codereview.chromium.org/350333003/) we won't need this code. Maybe a
good idea to make note of the patches you're landing to work around the issue so
we can remove them once this is fixed.

[commit-bot: I haz the power, 2014-11-10 17:08:04]

Committed patchset #1 (id:1) as 185045

[svillar, 2014-11-11 07:42:07]

On 2014/11/10 16:07:41, Timothy Loh wrote:
> On 2014/10/28 15:34:49, svillar wrote:
> 
> FYI eventually (when I or someone else get's around to rebasing
> https://codereview.chromium.org/350333003/) we won't need this code. Maybe a
> good idea to make note of the patches you're landing to work around the issue
so
> we can remove them once this is fixed.

Thanks for pointing this out. If everythings goes well, we will only have to
revert this once the other patch lands.