Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 680063004: [turbofan] Minor cleanups to lowering of typed array loads/stores. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Minor cleanups to lowering of typed array loads/stores. TEST=unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24917

Patch Set 1 #

Patch Set 2 : Fix win64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -61 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +0 lines, -36 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-10-28 08:06:42 UTC) #2
dcarney
lgtm
6 years, 1 month ago (2014-10-28 08:08:09 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-10-28 08:28:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24917 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698