Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Side by Side Diff: chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h

Issue 680053003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_EXTENSION_TOOLBAR_MENU_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_EXTENSION_TOOLBAR_MENU_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_EXTENSION_TOOLBAR_MENU_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_EXTENSION_TOOLBAR_MENU_VIEW_H_
7 7
8 #include "base/memory/weak_ptr.h" 8 #include "base/memory/weak_ptr.h"
9 #include "base/scoped_observer.h" 9 #include "base/scoped_observer.h"
10 #include "chrome/browser/ui/views/toolbar/browser_actions_container_observer.h" 10 #include "chrome/browser/ui/views/toolbar/browser_actions_container_observer.h"
11 #include "ui/views/view.h" 11 #include "ui/views/view.h"
12 12
13 class Browser; 13 class Browser;
14 class BrowserActionsContainer; 14 class BrowserActionsContainer;
15 class WrenchMenu; 15 class WrenchMenu;
16 16
17 // ExtensionToolbarMenuView is the view containing the extension actions that 17 // ExtensionToolbarMenuView is the view containing the extension actions that
18 // overflowed from the BrowserActionsContainer, and is contained in and owned by 18 // overflowed from the BrowserActionsContainer, and is contained in and owned by
19 // the wrench menu. 19 // the wrench menu.
20 // In the event that the WrenchMenu was opened for an Extension Action drag-and- 20 // In the event that the WrenchMenu was opened for an Extension Action drag-and-
21 // drop, this will also close the menu upon completion. 21 // drop, this will also close the menu upon completion.
22 class ExtensionToolbarMenuView : public views::View, 22 class ExtensionToolbarMenuView : public views::View,
23 public BrowserActionsContainerObserver { 23 public BrowserActionsContainerObserver {
24 public: 24 public:
25 ExtensionToolbarMenuView(Browser* browser, WrenchMenu* wrench_menu); 25 ExtensionToolbarMenuView(Browser* browser, WrenchMenu* wrench_menu);
26 virtual ~ExtensionToolbarMenuView(); 26 ~ExtensionToolbarMenuView() override;
27 27
28 // Returns whether the wrench menu should show this view. This is true when 28 // Returns whether the wrench menu should show this view. This is true when
29 // either |container_| has icons to display or the menu was opened for a drag- 29 // either |container_| has icons to display or the menu was opened for a drag-
30 // and-drop operation. 30 // and-drop operation.
31 bool ShouldShow(); 31 bool ShouldShow();
32 32
33 // views::View: 33 // views::View:
34 virtual gfx::Size GetPreferredSize() const override; 34 gfx::Size GetPreferredSize() const override;
35 virtual int GetHeightForWidth(int width) const override; 35 int GetHeightForWidth(int width) const override;
36 virtual void Layout() override; 36 void Layout() override;
37 37
38 private: 38 private:
39 // BrowserActionsContainerObserver: 39 // BrowserActionsContainerObserver:
40 virtual void OnBrowserActionDragDone() override; 40 void OnBrowserActionDragDone() override;
41 41
42 // Closes the |wrench_menu_|. 42 // Closes the |wrench_menu_|.
43 void CloseWrenchMenu(); 43 void CloseWrenchMenu();
44 44
45 // The associated browser. 45 // The associated browser.
46 Browser* browser_; 46 Browser* browser_;
47 47
48 // The WrenchMenu, which may need to be closed after a drag-and-drop. 48 // The WrenchMenu, which may need to be closed after a drag-and-drop.
49 WrenchMenu* wrench_menu_; 49 WrenchMenu* wrench_menu_;
50 50
51 // The overflow BrowserActionsContainer which is nested in this view. 51 // The overflow BrowserActionsContainer which is nested in this view.
52 BrowserActionsContainer* container_; 52 BrowserActionsContainer* container_;
53 53
54 ScopedObserver<BrowserActionsContainer, BrowserActionsContainerObserver> 54 ScopedObserver<BrowserActionsContainer, BrowserActionsContainerObserver>
55 browser_actions_container_observer_; 55 browser_actions_container_observer_;
56 56
57 base::WeakPtrFactory<ExtensionToolbarMenuView> weak_factory_; 57 base::WeakPtrFactory<ExtensionToolbarMenuView> weak_factory_;
58 58
59 DISALLOW_COPY_AND_ASSIGN(ExtensionToolbarMenuView); 59 DISALLOW_COPY_AND_ASSIGN(ExtensionToolbarMenuView);
60 }; 60 };
61 61
62 #endif // CHROME_BROWSER_UI_VIEWS_TOOLBAR_EXTENSION_TOOLBAR_MENU_VIEW_H_ 62 #endif // CHROME_BROWSER_UI_VIEWS_TOOLBAR_EXTENSION_TOOLBAR_MENU_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698