Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5449)

Unified Diff: chrome_frame/bho.cc

Issue 6800021: Merge 80497 - A change in the way User Agent is modified caused Chrome Frame to mistakenly disabl... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/696/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_frame/http_negotiate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/bho.cc
===================================================================
--- chrome_frame/bho.cc (revision 80663)
+++ chrome_frame/bho.cc (working copy)
@@ -84,19 +84,9 @@
DISALLOW_COPY_AND_ASSIGN(ReadyModeDelegateImpl);
}; // class ReadyModeDelegateImpl
-void SynchronizeEnablementState() {
- std::string user_agent(http_utils::GetDefaultUserAgent());
- bool enabled = user_agent.find("chromeframe") != std::string::npos;
- ProtocolSinkWrap::set_ignore_xua(!enabled);
-}
-
void ReadyModeDelegateImpl::DisableChromeFrame() {
- if (GetIEVersion() != IE_9) {
- SynchronizeEnablementState();
- } else {
- HttpNegotiatePatch::set_modify_user_agent(false);
- ProtocolSinkWrap::set_ignore_xua(true);
- }
+ HttpNegotiatePatch::set_modify_user_agent(false);
+ ProtocolSinkWrap::set_ignore_xua(true);
}
} // namespace
@@ -111,13 +101,6 @@
DCHECK(SUCCEEDED(hr)) << "DispEventAdvise failed. Error: " << hr;
ready_mode::Configure(new ReadyModeDelegateImpl(), web_browser2);
-
- // At this time, the user agent has been updated to reflect the Ready Mode
- // state. We should make sure to modify our recognition of meta tags
- // accordingly. On IE 9, another method is used to manage meta tags.
- if (GetIEVersion() != IE_9) {
- SynchronizeEnablementState();
- }
}
if (g_patch_helper.state() == PatchHelper::PATCH_IBROWSER) {
« no previous file with comments | « no previous file | chrome_frame/http_negotiate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698