Attn: Mike Belshe

chrome/browser/upgrade_detector.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/upgrade_detector.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 131 matching lines @@
 }  // namespace
 
 // static
 void UpgradeDetector::RegisterPrefs(PrefService* prefs) {
   prefs->RegisterBooleanPref(prefs::kRestartLastSessionOnShutdown, false);
 }
 
 UpgradeDetector::UpgradeDetector()
     : ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)),
       notify_upgrade_(false) {
+  CommandLine command_line(*CommandLine::ForCurrentProcess());
+  if (command_line.HasSwitch(switches::kDisableBackgroundNetworking))
+    return;

[Mike Belshe, 2011/04/06 18:32:53]

This is great - lets put this in a separate CL.

   // Windows: only enable upgrade notifications for official builds.
   // Mac: only enable them if the updater (Keystone) is present.
   // Linux (and other POSIX): always enable regardless of branding.
 #if (defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD)) || defined(OS_POSIX)
 #if defined(OS_MACOSX)
   if (keystone_glue::KeystoneEnabled())
 #endif
   {
     detect_upgrade_timer_.Start(
         base::TimeDelta::FromMilliseconds(GetCheckForUpgradeEveryMs()),
@@ skipping 40 matching lines @@
 }
 
 void UpgradeDetector::NotifyOnUpgrade() {
   notify_upgrade_ = true;
 
   NotificationService::current()->Notify(
       NotificationType::UPGRADE_RECOMMENDED,
       Source<UpgradeDetector>(this),
       NotificationService::NoDetails());
 }