Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 679973003: Revert of Enable virtual viewport on all platforms (Closed)

Created:
6 years, 1 month ago by leviw_travelin_and_unemployed
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable virtual viewport on all platforms (patchset #5 id:80001 of https://codereview.chromium.org/665963002/) Reason for revert: This appears to break the entire world as far as LayoutTests are concerned. Here's a small sample: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=css1%2Fbasic%2Fcontainment.html%2Ccss1%2Fbasic%2Fcomments.html%2Ccss1%2Fbasic%2Fgrouping.html%2Ccss1%2Fbasic%2Fclass_as_selector.html%2Ccss1%2Fbasic%2Finheritance.html%2Ccss1%2Fbasic%2Fcontextual_selectors.html%2Ccss1%2Fbasic%2Fid_as_selector.html Original issue's description: > Enable virtual viewport on all platforms except Android WebView. > > BUG=148816 > > Committed: https://crrev.com/e52372c24d2e1e9785703f0563ffc3423f7161cc > Cr-Commit-Position: refs/heads/master@{#301307} TBR=aelias@chromium.org,mkosiba@chromium.org,cpu@chromium.org,bokan@chromium.org NOTREECHECKS=true NOTRY=true BUG=148816 Committed: https://crrev.com/66210b6064d371b7a280d6ef4b41ae8152217fe7 Cr-Commit-Position: refs/heads/master@{#301311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
leviw_travelin_and_unemployed
Created Revert of Enable virtual viewport on all platforms
6 years, 1 month ago (2014-10-27 03:19:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679973003/1
6 years, 1 month ago (2014-10-27 03:21:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 03:21:28 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 03:21:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66210b6064d371b7a280d6ef4b41ae8152217fe7
Cr-Commit-Position: refs/heads/master@{#301311}

Powered by Google App Engine
This is Rietveld 408576698