Issue 679943004: Remove AstConstructionVisitor/AstNullVisitor

Issue 679943004: Remove AstConstructionVisitor/AstNullVisitor (Closed)

Created:
6 years, 1 month ago by wingo

Modified:
6 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+139 lines, -393 lines)			Patch
M	src/ast.h	View	14 chunks	+78 lines, -206 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+0 lines, -104 lines	0 comments	Download
M	src/parser.h	View	4 chunks	+18 lines, -26 lines	0 comments	Download
M	src/parser.cc	View	10 chunks	+24 lines, -29 lines	0 comments	Download
M	src/rewriter.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/scopes.h	View	4 chunks	+8 lines, -12 lines	0 comments	Download
M	src/scopes.cc	View	6 chunks	+8 lines, -11 lines	0 comments	Download
M	test/cctest/test-ast.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

wingo

Based on https://codereview.chromium.org/670953003/, PTAL once that one is reviewed. Thanks :)

6 years, 1 month ago (2014-10-27 07:46:17 UTC) #1

Sven Panne

LGTM, but let's wait until the bots are happy and we have some performance numbers ...

6 years, 1 month ago (2014-11-14 08:26:29 UTC) #2

wingo

On 2014/11/14 08:26:29, Sven Panne wrote: > LGTM, but let's wait until the bots are ...

6 years, 1 month ago (2014-11-14 08:47:32 UTC) #3

Sven Panne

On 2014/11/14 08:47:32, wingo wrote: > On 2014/11/14 08:26:29, Sven Panne wrote: > > LGTM, ...

6 years, 1 month ago (2014-11-14 10:20:55 UTC) #4

wingo

6 years, 1 month ago (2014-11-14 13:13:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4faa0ae88aaabdfe41e7d9c8dcfc6ee0484eaec4 (presubmit successful).