Switch to EnhancedBookmarkModel from meta_accessor

Switch to EnhancedBookmarkModel from meta_accessor

Meta_accessor is deprecated and we should use EnhancedBookmarkModel in
EnhancedBookmarkBridge. We might want to delete metadata_accessor files
after this CL.

BUG=415817
Committed: https://crrev.com/1dc2b410045e1e62a379146764d534c73e3d1b19
Cr-Commit-Position: refs/heads/master@{#301525}

[Ian Wen, 2014-10-25 04:36:17]

ianwen@chromium.org changed reviewers:
+ danduong@chromium.org, kkimlabs@chromium.org, tedchoc@chromium.org

[Ian Wen, 2014-10-25 04:39:59]

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc
(right):

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:41:
cluster_service_->RemoveObserver(this);
Why don't we delete cluster service and enhanced bookmark model here? I tried
but there was a DCHECK that forbid me from deleting it(LINE 144 in
bookmark_server_service.cc). However, if these services are not deleted, and the
user switches acount/profile, does it mean these objects will persist in memory?

[Kibeom Kim (inactive), 2014-10-26 05:34:56]

kkimlabs@chromium.org changed reviewers:
+ noyau@chromium.org, rfevang@google.com

[Kibeom Kim (inactive), 2014-10-26 05:34:57]

lgtm

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc
(left):

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:19:
#include "components/enhanced_bookmarks/metadata_accessor.h"
Can we delete metadata_accessor files with this CL?

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc
(right):

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:41:
cluster_service_->RemoveObserver(this);
On 2014/10/25 04:39:58, Ian Wen wrote:
> Why don't we delete cluster service and enhanced bookmark model here? I tried
> but there was a DCHECK that forbid me from deleting it(LINE 144 in
> bookmark_server_service.cc). However, if these services are not deleted, and
the
> user switches acount/profile, does it mean these objects will persist in
memory?

I think they are singleton (See BrowserContextKeyedServiceFactory) so we aren't
supposed to delete them.

And Chromium Profile class is not the same as the actual user account profile.

[Rune Fevang, 2014-10-27 19:52:26]

rfevang@chromium.org changed reviewers:
+ rfevang@chromium.org

[Rune Fevang, 2014-10-27 19:52:27]

lgtm

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc
(right):

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:66:
DCHECK(bookmark_model_->loaded());
Could you change these checks to enhanced_bookmark_model_->loaded()?

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
(right):

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h:51:
BookmarkModel* bookmark_model_;  // weak
You don't have to store the bookmark model any more, it is accessible from the
enhanced model (bookmark_model()).

[Rune Fevang, 2014-10-27 19:53:38]

rfevang@chromium.org changed reviewers:
- rfevang@google.com

[Ted C, 2014-10-27 19:56:38]

owners lgtm

[Ian Wen, 2014-10-27 23:06:32]

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc
(right):

https://codereview.chromium.org/679833002/diff/1/chrome/browser/android/enhan...
chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:66:
DCHECK(bookmark_model_->loaded());
On 2014/10/27 19:52:27, Rune Fevang wrote:
> Could you change these checks to enhanced_bookmark_model_->loaded()?

Done.

[Ian Wen, 2014-10-27 23:08:05]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2014-10-27 23:14:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/679833002/20001

[commit-bot: I haz the power, 2014-10-28 00:55:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-28 00:56:12]

Patchset 2 (id:??) landed as
https://crrev.com/1dc2b410045e1e62a379146764d534c73e3d1b19
Cr-Commit-Position: refs/heads/master@{#301525}