Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 679813004: Docserver: Add _query_commit handler (Closed)

Created:
6 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Docserver: Add _query_commit handler This adds a simple utility handler to allow developers to query named commit data stored in the CommitTracker. For example, to find out which commit's cache is supplying data to the live instance, one may query /_query_commit/master This also properly requires _enqueue and _refresh requests to come from authenticated users (i.e. admins or the cron job). BUG=None R=kalman@chromium.org NOTRY=True Committed: https://crrev.com/68c65a48b958c1a5e029cece19ef5eb01ab99fff Cr-Commit-Position: refs/heads/master@{#301385}

Patch Set 1 #

Total comments: 2

Patch Set 2 : documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -14 lines) Patch
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/handler.py View 1 3 chunks +44 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Ken Rockot(use gerrit already)
A little patch
6 years, 2 months ago (2014-10-25 00:41:16 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/679813004/diff/1/chrome/common/extensions/docs/server2/handler.py File chrome/common/extensions/docs/server2/handler.py (right): https://codereview.chromium.org/679813004/diff/1/chrome/common/extensions/docs/server2/handler.py#newcode32 chrome/common/extensions/docs/server2/handler.py:32: class _QueryCommitServlet(Servlet): comments
6 years, 2 months ago (2014-10-25 01:26:15 UTC) #2
Ken Rockot(use gerrit already)
https://codereview.chromium.org/679813004/diff/1/chrome/common/extensions/docs/server2/handler.py File chrome/common/extensions/docs/server2/handler.py (right): https://codereview.chromium.org/679813004/diff/1/chrome/common/extensions/docs/server2/handler.py#newcode32 chrome/common/extensions/docs/server2/handler.py:32: class _QueryCommitServlet(Servlet): On 2014/10/25 01:26:14, kalman wrote: > comments ...
6 years, 1 month ago (2014-10-27 17:02:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679813004/20001
6 years, 1 month ago (2014-10-27 17:04:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 17:10:28 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 17:11:14 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68c65a48b958c1a5e029cece19ef5eb01ab99fff
Cr-Commit-Position: refs/heads/master@{#301385}

Powered by Google App Engine
This is Rietveld 408576698