Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 679813002: [telemetry] Drop data for sysfs power monitor if distribution changes but total does not. (Closed)

Created:
6 years, 2 months ago by dtu
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Drop data for sysfs power monitor if distribution changes but total does not. The log showed that the sum across all C-states didn't change, but C0 went down and WFI went up. AFAIK it shouldn't be possible for any of them to go down, so we'll just drop the data in this case. BUG=426430 TEST=None. TBR=tonyg Committed: https://crrev.com/3598d35dced5eb1bd2f061c9a576a442c4c24cbf Cr-Commit-Position: refs/heads/master@{#302492}

Patch Set 1 #

Patch Set 2 : Unit tests. #

Total comments: 2

Patch Set 3 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor_unittest.py View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dtu
6 years, 1 month ago (2014-10-31 21:23:04 UTC) #2
Andrew Hayden (chromium.org)
LGTM https://codereview.chromium.org/679813002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/679813002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py#newcode173 tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py:173: if total == 0: Please add a comment ...
6 years, 1 month ago (2014-11-03 12:22:39 UTC) #4
dtu
TBRing to greenify https://codereview.chromium.org/679813002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/679813002/diff/20001/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py#newcode173 tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py:173: if total == 0: On 2014/11/03 ...
6 years, 1 month ago (2014-11-03 20:19:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679813002/40001
6 years, 1 month ago (2014-11-03 20:19:27 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-03 21:52:15 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 21:52:41 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3598d35dced5eb1bd2f061c9a576a442c4c24cbf
Cr-Commit-Position: refs/heads/master@{#302492}

Powered by Google App Engine
This is Rietveld 408576698