Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: src/native_client/src/trusted/service_runtime/sel_main_chrome.c

Issue 6798008: Add an assertion to check that Chrome/Breakpad does not install a signal handler (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Use %d; amend Windows comment Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/native_client/src/trusted/service_runtime/sel_main_chrome.c
diff --git a/src/native_client/src/trusted/service_runtime/sel_main_chrome.c b/src/native_client/src/trusted/service_runtime/sel_main_chrome.c
index e1fc3c7830797a90414c74d37067179533726b61..94ec25197842c5443ac964169b146d3f937e1ee4 100644
--- a/src/native_client/src/trusted/service_runtime/sel_main_chrome.c
+++ b/src/native_client/src/trusted/service_runtime/sel_main_chrome.c
@@ -105,12 +105,14 @@ int NaClMainForChromium(int handle_count, const NaClHandle *handles,
fprintf(stderr, "Error while loading in SelMain: %s\n",
NaClErrorString(errcode));
}
+ /* Remove the handler that was used for platform qualification tests. */
+ NaClSignalHandlerFini();
/*
- * Remove the handler and let error pass to Chrome's handlers.
+ * Check that Chrome did not register any signal handlers, because
+ * these are not always safe.
*/
- NaClSignalHandlerFini();
-
+ NaClSignalAssertNoHandlers();
/* Give debuggers a well known point at which xlate_base is known. */
NaClGdbHook(&state);

Powered by Google App Engine
This is Rietveld 408576698