Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: ui/views/controls/webview/unhandled_keyboard_event_handler_win.cc

Issue 679743002: MacViews: UnhandledKeyboardEventHandler stub (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/controls/webview/unhandled_keyboard_event_handler.h" 5 #include "ui/views/controls/webview/unhandled_keyboard_event_handler.h"
6 6
7 #include "base/logging.h"
8 #include "content/public/browser/native_web_keyboard_event.h"
9 #include "ui/events/event.h" 7 #include "ui/events/event.h"
10 #include "ui/views/focus/focus_manager.h"
11
12 using content::NativeWebKeyboardEvent;
13 8
14 namespace views { 9 namespace views {
15 10
16 UnhandledKeyboardEventHandler::UnhandledKeyboardEventHandler() { 11 // static
17 ignore_next_char_event_ = false; 12 void UnhandledKeyboardEventHandler::HandleNativeKeyboardEvent(
18 } 13 gfx::NativeEvent event,
19
20 void UnhandledKeyboardEventHandler::HandleKeyboardEvent(
21 const NativeWebKeyboardEvent& event,
22 FocusManager* focus_manager) { 14 FocusManager* focus_manager) {
23 if (!focus_manager) {
24 NOTREACHED();
25 return;
26 }
27 // Previous calls to TranslateMessage can generate Char events as well as
28 // RawKeyDown events, even if the latter triggered an accelerator. In these
29 // cases, we discard the Char events.
30 if (event.type == blink::WebInputEvent::Char && ignore_next_char_event_) {
31 ignore_next_char_event_ = false;
32 return;
33 }
34 // It's necessary to reset this flag, because a RawKeyDown event may not
35 // always generate a Char event.
36 ignore_next_char_event_ = false;
37
38 if (event.type == blink::WebInputEvent::RawKeyDown) {
39 ui::Accelerator accelerator(
40 static_cast<ui::KeyboardCode>(event.windowsKeyCode),
41 content::GetModifiersFromNativeWebKeyboardEvent(event));
42
43 // This is tricky: we want to set ignore_next_char_event_ if
44 // ProcessAccelerator returns true. But ProcessAccelerator might delete
45 // |this| if the accelerator is a "close tab" one. So we speculatively
46 // set the flag and fix it if no event was handled.
47 ignore_next_char_event_ = true;
48
49 if (focus_manager->ProcessAccelerator(accelerator)) {
50 return;
51 }
52
53 // ProcessAccelerator didn't handle the accelerator, so we know both
54 // that |this| is still valid, and that we didn't want to set the flag.
55 ignore_next_char_event_ = false;
56 }
57
58 // Any unhandled keyboard/character messages should be defproced. 15 // Any unhandled keyboard/character messages should be defproced.
59 // This allows stuff like F10, etc to work correctly. 16 // This allows stuff like F10, etc to work correctly.
60 if (!event.os_event) 17 const MSG& message(event->native_event());
61 return;
62 const MSG& message(event.os_event->native_event());
63 DefWindowProc(message.hwnd, message.message, message.wParam, message.lParam); 18 DefWindowProc(message.hwnd, message.message, message.wParam, message.lParam);
64 } 19 }
65 20
66 } // namespace views 21 } // namespace views
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698