Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 679743002: MacViews: UnhandledKeyboardEventHandler stub (Closed)

Created:
6 years, 1 month ago by Andre
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MacViews: UnhandledKeyboardEventHandler stub Fix for missing UnhandledKeyboardEventHandler::HandleNativeKeyboardEvent on Mac, in preparation for compiling chrome/browser/ui/views for MacViews. Consolidate duplicated linux/windows code to be shared code and stub out the Mac implementation. BUG=425229 Committed: https://crrev.com/f5d10685b975dd11be315133a099a8a980ad0716 Cr-Commit-Position: refs/heads/master@{#301198}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -99 lines) Patch
M ui/views/controls/webview/unhandled_keyboard_event_handler.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/controls/webview/unhandled_keyboard_event_handler.cc View 1 chunk +49 lines, -0 lines 2 comments Download
M ui/views/controls/webview/unhandled_keyboard_event_handler_linux.cc View 1 chunk +4 lines, -48 lines 0 comments Download
A + ui/views/controls/webview/unhandled_keyboard_event_handler_mac.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/views/controls/webview/unhandled_keyboard_event_handler_win.cc View 1 chunk +4 lines, -49 lines 0 comments Download
M ui/views/controls/webview/webview.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Andre
sky@ PTAL. We are starting work to build chrome/browser/ui/views for MacViews.
6 years, 1 month ago (2014-10-24 16:50:12 UTC) #2
sky
https://codereview.chromium.org/679743002/diff/1/ui/views/controls/webview/unhandled_keyboard_event_handler.cc File ui/views/controls/webview/unhandled_keyboard_event_handler.cc (right): https://codereview.chromium.org/679743002/diff/1/ui/views/controls/webview/unhandled_keyboard_event_handler.cc#newcode57 ui/views/controls/webview/unhandled_keyboard_event_handler.cc:57: if (event.os_event && !event.skip_in_browser) The win side previously didn't ...
6 years, 1 month ago (2014-10-24 18:11:19 UTC) #3
Andre
https://codereview.chromium.org/679743002/diff/1/ui/views/controls/webview/unhandled_keyboard_event_handler.cc File ui/views/controls/webview/unhandled_keyboard_event_handler.cc (right): https://codereview.chromium.org/679743002/diff/1/ui/views/controls/webview/unhandled_keyboard_event_handler.cc#newcode57 ui/views/controls/webview/unhandled_keyboard_event_handler.cc:57: if (event.os_event && !event.skip_in_browser) On 2014/10/24 18:11:19, sky wrote: ...
6 years, 1 month ago (2014-10-24 18:36:02 UTC) #4
sky
Ok, LGTM
6 years, 1 month ago (2014-10-24 19:31:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679743002/1
6 years, 1 month ago (2014-10-24 20:16:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-24 21:36:53 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 21:37:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5d10685b975dd11be315133a099a8a980ad0716
Cr-Commit-Position: refs/heads/master@{#301198}

Powered by Google App Engine
This is Rietveld 408576698