Reduce runtime of client_cert_resolver_unittest

Reduce runtime of client_cert_resolver_unittest

Enabling the unit tests again on debug.
If they still timeout, please revert.

Several changes to reduce the runtime:
- Ensure that there are no duplicate Shill profile notifications, which triggered multiple policy applications and certificate resolves.
- Ensure that each test runs at most one certificate resolve task.
- Use other certificates that are faster to load and import.

Overall this reduce on my workstation runtime in debug from ~6 seconds to <4 seconds.

Also remove the unnecessary TPMTokenLoader initialization.

BUG=418369
Committed: https://crrev.com/d0f72112a76c7b3449875478fce65f7d0b4b98e9
Cr-Commit-Position: refs/heads/master@{#301091}

[pneubeck (no reviews), 2014-10-24 11:09:01]

pneubeck@chromium.org changed reviewers:
+ joaodasilva@chromium.org

[pneubeck (no reviews), 2014-10-24 11:09:01]

ptal

[Joao da Silva, 2014-10-24 12:01:07]

Looks reasonable, lgtm

https://codereview.chromium.org/679673002/diff/1/chromeos/network/client_cert...
File chromeos/network/client_cert_resolver_unittest.cc (left):

https://codereview.chromium.org/679673002/diff/1/chromeos/network/client_cert...
chromeos/network/client_cert_resolver_unittest.cc:248: void
CleanupSlotContents() {
Are you sure this can be removed? Can't it interfere with subsequent test runs
if a test leaves certs behind?

https://codereview.chromium.org/679673002/diff/1/chromeos/network/network_pro...
File chromeos/network/network_profile_handler.cc (right):

https://codereview.chromium.org/679673002/diff/1/chromeos/network/network_pro...
chromeos/network/network_profile_handler.cc:114: for (const std::string
profile_path : removed_profile_paths) {
const&

(you can also use const auto&)

[pneubeck (no reviews), 2014-10-24 12:33:52]

https://codereview.chromium.org/679673002/diff/1/chromeos/network/client_cert...
File chromeos/network/client_cert_resolver_unittest.cc (left):

https://codereview.chromium.org/679673002/diff/1/chromeos/network/client_cert...
chromeos/network/client_cert_resolver_unittest.cc:248: void
CleanupSlotContents() {
On 2014/10/24 12:01:06, Joao da Silva wrote:
> Are you sure this can be removed? Can't it interfere with subsequent test runs
> if a test leaves certs behind?

Yes. Databases in temporary directories/files are used.

https://codereview.chromium.org/679673002/diff/1/chromeos/network/network_pro...
File chromeos/network/network_profile_handler.cc (right):

https://codereview.chromium.org/679673002/diff/1/chromeos/network/network_pro...
chromeos/network/network_profile_handler.cc:114: for (const std::string
profile_path : removed_profile_paths) {
On 2014/10/24 12:01:06, Joao da Silva wrote:
> const&
> 
> (you can also use const auto&)

Done.

[pneubeck (no reviews), 2014-10-24 12:34:30]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-10-24 12:35:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/679673002/20001

[commit-bot: I haz the power, 2014-10-24 13:30:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-24 13:30:55]

Patchset 2 (id:??) landed as
https://crrev.com/d0f72112a76c7b3449875478fce65f7d0b4b98e9
Cr-Commit-Position: refs/heads/master@{#301091}